Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Adds ariaQuestion field to JSON default settings (fixes: 3353) #3354

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix: Adds ariaQuestion field to JSON default settings (fixes: 3353) #3354

merged 1 commit into from
Jan 16, 2023

Conversation

joe-replin
Copy link
Contributor

Fix

Testing

  1. Install PR
  2. Ensure latest fixes to question components are added
  3. Adjust ariaQuestion field and listen to output via screen reader

Testing is dependent on the successful approval of the following issues:
adaptlearning/adapt-contrib-mcq#190
adaptlearning/adapt-contrib-slider#170
adaptlearning/adapt-contrib-gmcq#157
adaptlearning/adapt-contrib-matching#159
adaptlearning/adapt-contrib-textInput#121

@joe-replin joe-replin self-assigned this Jan 6, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit d52ab06 into master Jan 16, 2023
@joe-allen-89 joe-allen-89 deleted the issue/3353 branch January 16, 2023 11:17
github-actions bot pushed a commit that referenced this pull request Jan 16, 2023
@semantic-release-bot
Chore(release): 5.24.8 [skip ci]
0727f1a 
## [5.24.8](v5.24.7...v5.24.8) (2023-01-16)

### Fix

* Adds ariaQuestion field to all question components (#3354) ([d52ab06](d52ab06)), closes [#3354](#3354)
@github-actions
Copy link

🎉 This PR is included in version 5.24.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@joe-replin joe-replin

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display ariaQuestion field in JSON default settings
4 participants
@joe-replin @oliverfoster @cahirodoherty-learningpool @joe-allen-89