-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue/2824 Switch to rollup from requirejs #2923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Looks fantastic, only issue I saw was a |
@moloko Could you +1 when you get a mo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code 👓
#2824
This version does not have the react elements, it is merely to fix the currently broken build process in v5.
Will provide an almost seamless migration away from build-side requirejs and AMD modules to ES6 modules.
Facilitates
import
andexport
directivesvar Adapt = require('core/js/adapt');
etc will still work in the console and for other pluginsDownsides
js
folderconstructor
function without thenew
keyword is not allowed - which is an essential part of the way Backbone constructs classes.Added
<%= outputdir %>/.cache
to speed up compilation times--disable-cache
to disable the cache and recompile from scratchRemoved
config.js
file has been moved to thejavascript
grunt task configFixed
QuestionView
has two differentreturn
statements, so cannot resolve to oneexport default
directiveTesting
Example
Shows fast compilation times,
import
/export
, debugging andrequire
functioning with an ES6 module in the client-side: