Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-contrib-spoor: Unable to set commitOnStatusChange setting to false #2943

Closed
chogben opened this issue Oct 15, 2020 · 0 comments · Fixed by adaptlearning/adapt-contrib-spoor#203

Comments

@chogben
Copy link

chogben commented Oct 15, 2020

When publishing a course with Spoor and the setting _commitOnStatusChange set to false, it is not picked up and set during runtime.

It appears as though the if statement around the setting assignment only checks for true values[0], and as the default value is already true[1], it can never be set to false.

This got us in our older LMS platform which requires this setting to be set to false.

I opened a PR for a proposed fix here: adaptlearning/adapt-contrib-spoor#203

[0] https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/js/adapt-stateful-session.js#L57
[1] https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/js/scorm/wrapper.js#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant