You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When publishing a course with Spoor and the setting _commitOnStatusChange set to false, it is not picked up and set during runtime.
It appears as though the if statement around the setting assignment only checks for true values[0], and as the default value is already true[1], it can never be set to false.
This got us in our older LMS platform which requires this setting to be set to false.
When publishing a course with Spoor and the setting _commitOnStatusChange set to false, it is not picked up and set during runtime.
It appears as though the if statement around the setting assignment only checks for true values[0], and as the default value is already true[1], it can never be set to false.
This got us in our older LMS platform which requires this setting to be set to false.
I opened a PR for a proposed fix here: adaptlearning/adapt-contrib-spoor#203
[0] https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/js/adapt-stateful-session.js#L57
[1] https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/js/scorm/wrapper.js#L31
The text was updated successfully, but these errors were encountered: