Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 'src/course' folder in favour of 'build/course' #2363

Closed
oliverfoster opened this issue Feb 25, 2019 · 3 comments · Fixed by #2644 · May be fixed by #3370
Closed

Drop 'src/course' folder in favour of 'build/course' #2363

oliverfoster opened this issue Feb 25, 2019 · 3 comments · Fixed by #2644 · May be fixed by #3370
Assignees
@oliverfoster
Labels
enhancement

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Feb 25, 2019 •
edited
Loading

Advantages

  • makes src folder "code only"
  • unifies build pathways across AAT and Fwk
  • deduplicates course assets when stored on disk
  • allows developers to concentrate on build output
  • simplifies grunt code

Suggested timeline

Release with v6
@oliverfoster oliverfoster self-assigned this Feb 25, 2019
@tomgreenfield
Copy link
Contributor

tomgreenfield commented Feb 25, 2019 •
edited by oliverfoster
Loading

Please also include cleaning of build folder.

Reference: adaptlearning/adapt_authoring#2235.

Edited: grunt clean does this ref

@guywillis guywillis mentioned this issue Feb 28, 2019
Closed
@tomgreenfield tomgreenfield mentioned this issue Apr 11, 2019
Closed
@guywillis
Copy link
Contributor

👍

@oliverfoster oliverfoster mentioned this issue Feb 10, 2020
Merged
@oliverfoster oliverfoster added this to the Adapt v6 milestone Feb 11, 2020
@oliverfoster oliverfoster linked a pull request Mar 9, 2020 that will close this issue
issue/2363 drop src/course pathway in grunt #2644
Merged
@oliverfoster oliverfoster reopened this May 11, 2021
@oliverfoster oliverfoster mentioned this issue May 12, 2021
Closed
@oliverfoster oliverfoster moved this from New to Backlog in adapt_framework: The TODO Board Jul 19, 2022
@oliverfoster oliverfoster moved this from Backlog to Assigned in adapt_framework: The TODO Board Aug 15, 2022
@oliverfoster oliverfoster mentioned this issue Aug 18, 2022
Closed
@oliverfoster oliverfoster moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Aug 18, 2022
@oliverfoster oliverfoster moved this from Needs Reviewing to Backlog in adapt_framework: The TODO Board Dec 6, 2022
@oliverfoster oliverfoster removed this from the Adapt v6 milestone Jan 16, 2023
@oliverfoster oliverfoster mentioned this issue Mar 2, 2023
Draft
@oliverfoster oliverfoster moved this from Backlog to Assigned in adapt_framework: The TODO Board Mar 2, 2023
@oliverfoster
Copy link
Member Author

duplicate

@github-project-automation github-project-automation bot moved this from Assigned to Recently Released in adapt_framework: The TODO Board Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@tomgreenfield @oliverfoster @guywillis