Editable theme check is not robust enough

[tomgreenfield]

We have some legacy themes which are wrongly identified as being editable because they contain more than one property in their schema i.e. both _screenSize and pluginLocations.

adapt_authoring/frontend/src/modules/editor/themeEditor/views/editorThemingView.js

Lines 418 to 433 in 169df20

	themeIsEditable: function(theme) {
	var props = theme && theme.get('properties');
	if (!props) {
	return false;
	}
	if (Object.keys(props).length === 1) {
	if (props.hasOwnProperty('pluginLocations')) {
	return false;
	}
	// For old themes
	if (props.hasOwnProperty('_screenSize')) {
	return false;
	}
	}
	return true;
	},

Since we switched to having all theme variables in a nested object, this function can be greatly simplified to something like:

themeIsEditable: function(theme) {
  var props = theme && theme.get('properties');

  return props && props.variables;
}

Versions

• Authoring Tool Version: 0.8.1
• Framework Version: 2.4.0