Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme editing issues #2358

Closed
danielstorey opened this issue Jun 9, 2019 · 3 comments
Closed

Theme editing issues #2358

danielstorey opened this issue Jun 9, 2019 · 3 comments
Labels
S: merged Completed, reviewed, and merged issues

Comments

@danielstorey
Copy link
Member

Expected Behaviour

a) I should be able to select a transparent (rgba) colour for my theme
b) I should be able to specify a select option for a theme variable in the theme's properties schema

Actual Behaviour

a) colour is saved as hex, so any alpha value selected using the colour picker is lost
b) a script error occurs as EditorThemingView assumes fieldView.schema.inputType is a string

Steps to Reproduce

a) select a transparent colour in the theme editor, save and preview theme.
b) create a theme with at least one property where InputType is { "type": "Select", "options": [...] }

Versions

  • Authoring Tool Version: 0.8.0
  • Framework Version: 4.2.0
@canstudios-nicolaw canstudios-nicolaw added this to the Bugpatch milestone Jun 17, 2019
@canstudios-nicolaw
Copy link
Contributor

Part a) of this has been fixed on the bugpatch branch. This should be mentioned in any release notes etc.

@danielstorey
Copy link
Member Author

Part b) should be fixed as well ;)

@canstudios-nicolaw
Copy link
Contributor

Brilliant, I'll add a merged tag :)

@canstudios-nicolaw canstudios-nicolaw added the S: merged Completed, reviewed, and merged issues label Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: merged Completed, reviewed, and merged issues
Projects
None yet
Development

No branches or pull requests

2 participants