Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install breaks if any config values contain true/false #2133

Closed
taylortom opened this issue Nov 14, 2018 · 1 comment
Closed

Install breaks if any config values contain true/false #2133

taylortom opened this issue Nov 14, 2018 · 1 comment
Labels
I: minor Low, impact, low priority bugs T: bug

Comments

@taylortom
Copy link
Member

The Json parse/stringify hack here causes an uncaught error if any of the config values contain true/false, as they're replaced with "y"/"n" (too many double-quotes).

"someString=true" => "someString="y""

Came across this when using a dbConnectionUri to connect to a MongoDB Atlas cluster.

Affects AAT version: 0.6.1
@taylortom taylortom added T: bug I: minor Low, impact, low priority bugs labels Nov 14, 2018
@tomgreenfield
Copy link
Contributor

This hack is removed in #2520.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: minor Low, impact, low priority bugs T: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomgreenfield @taylortom