Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpers.hasCoursePermission returns without calling callback on error #2113

Closed
taylortom opened this issue Oct 26, 2018 · 1 comment
Closed

Helpers.hasCoursePermission returns without calling callback on error #2113

taylortom opened this issue Oct 26, 2018 · 1 comment
Assignees
@lc-thomasberger
Labels
I: minor Low, impact, low priority bugs S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.7.0 Loose ends

Comments

@taylortom
Copy link
Member

taylortom commented Oct 26, 2018 •
edited
Loading

See the following:

adapt_authoring/lib/helpers.js

Lines 150 to 153 in 7f1a23f

if (err) {
logger.log('error', err);
return err;
}

@taylortom taylortom added T: bug I: minor Low, impact, low priority bugs labels Oct 26, 2018
@lc-thomasberger lc-thomasberger self-assigned this Dec 19, 2018
@lc-thomasberger lc-thomasberger added this to the 0.7.0 Loose ends milestone Dec 19, 2018
@lc-thomasberger
Copy link
Member

will probaly be fixed in #2124

@taylortom taylortom added the S: awaiting-review Completed issues waiting on reviews label Feb 14, 2019
@lc-thomasberger lc-thomasberger mentioned this issue Feb 15, 2019
Merged
@lc-thomasberger lc-thomasberger added S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lc-thomasberger lc-thomasberger

Labels
I: minor Low, impact, low priority bugs S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.7.0 Loose ends
Development

No branches or pull requests
3 participants
@taylortom @lc-thomasberger @canstudios-nicolaw