Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password reset displays error alert on success #2075

Closed
taylortom opened this issue Sep 12, 2018 · 0 comments
Closed

Password reset displays error alert on success #2075

taylortom opened this issue Sep 12, 2018 · 0 comments
Labels
D: easy Straightforward issues, small time commitment S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.6.1

Comments

@taylortom
Copy link
Member

The original calling code does a Backbone.Model.save, which causes the underlying $.ajax call to expect a JSON response, but we just do res.status(200).end() on the server side. Changing the response code to res.status(200).json({}) fixes this (could also return the user).

See plugins/auth/local/index.js#L199-L222.
@taylortom taylortom added T: bug D: easy Straightforward issues, small time commitment help wanted Suitable for community members, small time commitment labels Sep 12, 2018
@taylortom taylortom added this to the 0.5.1 milestone Sep 12, 2018
@taylortom taylortom removed the help wanted Suitable for community members, small time commitment label Sep 12, 2018
@taylortom taylortom mentioned this issue Sep 12, 2018
Merged
@taylortom taylortom added the S: awaiting-review Completed issues waiting on reviews label Sep 13, 2018
@taylortom taylortom added S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D: easy Straightforward issues, small time commitment S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.6.1
Development

No branches or pull requests
1 participant
@taylortom