Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Tests #1705

Closed
canstudios-louisem opened this issue Aug 16, 2017 · 3 comments
Closed

Backend Tests #1705

canstudios-louisem opened this issue Aug 16, 2017 · 3 comments
Labels
D: hard Complex issues, require discussion and big time commitment Epic T: enhancement Adding additional functionality

Comments

@canstudios-louisem
Copy link
Contributor

Currently, our test coverage is quite poor, here is the coverage calculation by NYC:

Statements   : 45.15% ( 2737/6062 )
Branches: 30.61% ( 888/2901 )
Functions: 45.55% ( 584/1282 )
Lines: 45.27% ( 2736/6044 )

I think it is actually lower than this as there are files tests simply don't touch.

In my opinion, we should be a lot stricter about tests being included in pr's.

A tool I have used in the past is https://coveralls.io/ which I found quite helpful to track coverage and make sure any pr's or features didn't make things worse.

I don't think we need to be chasing 100% you just end up writing tests for the sake of coverage but 80-90% would give us a lot more confidence and would allow us to leverage other tools that run off the ci more effectivly.

@canstudios-louisem canstudios-louisem changed the title rs Backend Tests Aug 16, 2017
@taylortom
Copy link
Member

taylortom commented Aug 16, 2017

Yeah, as mentioned on the call these were added initially and not kept up-to-date.

I suggest we set up a working group to look into all unit tests after the 0.4.1 patch release, and alongside tenant management and import/export; I'll have time to donate to this as I'm not involved in those.

@canstudios-louisem
Copy link
Contributor Author

Works for me I just wanted to get something down while it was in my head.

@canstudios-louisem canstudios-louisem added Epic D: hard Complex issues, require discussion and big time commitment labels Aug 18, 2017
@canstudios-louisem canstudios-louisem added this to the 0.?.0 Unit Test Updates milestone Aug 22, 2017
@taylortom taylortom modified the milestones: 0.?.0 Unit Test Updates, 0.8.0 Backend refactor Jun 5, 2018
@taylortom taylortom added the T: enhancement Adding additional functionality label Mar 26, 2019
@taylortom
Copy link
Member

Closing due to inactivity (will be covered by rewrite)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: hard Complex issues, require discussion and big time commitment Epic T: enhancement Adding additional functionality
Projects
None yet
Development

No branches or pull requests

2 participants