Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: restore matching dropdown options focus/selected highlight (fixes #525) #526

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix: restore matching dropdown options focus/selected highlight (fixes #525) #526

merged 1 commit into from
Sep 9, 2024

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Sep 5, 2024 •
edited
Loading

Fixes #525
Fixes adaptlearning/adapt-contrib-matching#193

Fix

Testing

  • Tab to a Matching component, select Enter to expand the dropdown button.
  • Use up / down arrows to navigate between the options.
  • Use spacebar to select an option.

The option receiving focus should be highlighted.
The selected option should be highlighted.

@kirsty-hames
restore matching dropdown options focus/selected highlight
56a55f5 
When navigating dropdown options via keyboard up/down arrows, there's no visual focus/highlight.

Issue introduced during previous PR (Fix 2): #507
@kirsty-hames kirsty-hames self-assigned this Sep 5, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 05424bc into master Sep 9, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/525 branch September 9, 2024 10:52
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
@semantic-release-bot
Chore(release): 9.20.1 [skip ci]
7379316 
## [9.20.1](v9.20.0...v9.20.1) (2024-09-09)

### Fix

* restore matching dropdown options focus/selected highlight (fixes #526) ([05424bc](05424bc)), closes [#526](#526) [#507](#507)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

🎉 This PR is included in version 9.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89