Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Boxmenu item graphic margin to support latest template amends (fixes #520) #521

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #520

Fix

  • Apply margin to .boxmenu-item__details instead of .boxmenu-item__image-container. No visual change to the menu item spacing, just the application. When no image exists, margin isn't applied.

Testing

Please test with both Boxmenu master branch and issue/198.

@kirsty-hames kirsty-hames self-assigned this Jul 2, 2024
@kirsty-hames kirsty-hames changed the title Update: update item graphic margin to support latest template amends (fixes #520) Update: update Boxmenu item graphic margin to support latest template amends (fixes #520) Jul 2, 2024
@kirsty-hames kirsty-hames changed the title Update: update Boxmenu item graphic margin to support latest template amends (fixes #520) Update: Boxmenu item graphic margin to support latest template amends (fixes #520) Jul 2, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 25dd6b7 into master Jul 8, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/520 branch July 8, 2024 09:11
Copy link

github-actions bot commented Jul 8, 2024

🎉 This PR is included in version 9.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxmenu: update item graphic margin to support latest template amends
4 participants