Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Graphic background color when using graphics as pins #453

Closed
swashbuck opened this issue Feb 6, 2023 · 1 comment · Fixed by #454
Closed

Hot Graphic background color when using graphics as pins #453

swashbuck opened this issue Feb 6, 2023 · 1 comment · Fixed by #454
Assignees

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Feb 6, 2023

Subject of the issue

When using graphics as pins, the button.hotgraphic__pin element inherits the background color from .btn-icon. As such, you can see the button's background color when using transparent PNGs.

In this example, standard buttons have a gray background. This color is visible behind the star pin graphics:

hotgraphic-pin

Your environment

  • Framework 5.24.8
  • Vanilla theme 9.3.1
  • Hot Graphic 6.5.2

Steps to reproduce

  1. Add a Hotgraphic.
  2. Configure to use a graphic for a pin with the_pin option:
"_pin": {
    "src": "course/en/images/hotgraphic-pin.png",
    "alt": ""
}

Suggested next steps

Couple ideas for this:

  1. (preferred) Always use a transparent background for graphic pins.
.hotgraphic__pin.has-pin-image {
  background-color: transparent;
}
  1. Add a new setting called _isTransparent that would live in the _pin object. When this is true, the background color would be set to transparent.
@swashbuck swashbuck added the bug label Feb 6, 2023
@swashbuck swashbuck changed the title Background color when using graphics as pins Hot Graphic background color when using graphics as pins Jul 7, 2023
@swashbuck swashbuck transferred this issue from adaptlearning/adapt-contrib-hotgraphic Jul 7, 2023
@swashbuck swashbuck self-assigned this Jul 7, 2023
@swashbuck swashbuck moved this from Awaiting Response to Needs Reviewing in adapt_framework: The TODO Board Jul 7, 2023
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jul 17, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 9.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants