Update: Make item titles optional, create fallback title for dialogs and strapline buttons (fixes #308)

[swashbuck]

Fix #308

Update

• Make _items titles optional
• Adds new generic fallback title _globals._components._narrative.titleDialog for strapline dialogs. This will only be used by screenreaders and will not be visually displayed. Defaults to Item {{itemNumber}} of {{totalItems}}.
• Adds new generic fallback title _globals._components._narrative.titleStrapline for strapline buttons. Defaults to "Find out more"

Rework strapline dialog titles to use one of the following properties (sorted by precedence):

1. _items title
2. _items strapline
3. _globals._components._narrative.titleDialog

Rework strapline button titles to use one of the following properties (sorted by precedence):

1. _items strapline
2. _items title
3. _globals._components._narrative.titleStrapline

[kirsty-hames]

The fallback title for notify dialog works as expected thanks @swashbuck.

However, having required title meant the strapline button always had a title. In the instance no title or strapline is set, .narrative__strapline-btn has no visual text or aria-label and the button collapses. See screen shot below.

To prevent this we could do one of the following:

• provide a default strapline title e.g. "Find out more"
• set titleDialog as strapline title.
• set titleDialog as the strapline aria-label (no visual text) and prevent the button collapsing with a styling fix.

Thoughts on above or alternative solutions welcomed?

[swashbuck]

However, having required title meant the strapline button always had a title. In the instance no title or strapline is set, .narrative__strapline-btn has no visual text or aria-label and the button collapses.

To prevent this we could do one of the following:
* provide a default strapline title e.g. "Find out more"
* set titleDialog as strapline title.
* set titleDialog as the strapline aria-label (no visual text) and prevent the button collapsing with a styling fix.

@kirsty-hames I like the idea of having of a default strapline title (titleStrapline). It should then be obvious to course creators (in theory) that they need to set a "real" value for strapline if they do not want the generic fallback text.

This is another case where we need a better form library in the AAT. strapline should be a required field if the Narrative uses the strapline layout. Otherwise, it should not be required. The current form library doesn't have the capability of making fields conditionally required. But that's a matter for another day :)

[kirsty-hames]

Works as expected thanks 👍

[cahirodoherty-learningpool]

Hi @swashbuck
I think the PR title should be changed to be an Update: ... type as new properties have been added

[joe-allen-89]

👍

[github-actions]

🎉 This PR is included in version 7.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀