Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Keep active item position on save/restore (fixes #295) #296

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Fix: Keep active item position on save/restore (fixes #295) #296

merged 4 commits into from
Feb 5, 2024

Conversation

oliverfoster
Copy link
Member

fixes #295

Fix

  • Fix: Keep active item position on save/restore

Requires adaptlearning/adapt-contrib-core#494

@oliverfoster oliverfoster self-assigned this Jan 31, 2024
@oliverfoster oliverfoster mentioned this pull request Jan 31, 2024
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 working nicely.

@joe-allen-89
Copy link
Contributor

Wait for Core and bump FW before release!

@joe-allen-89 joe-allen-89 merged commit 1c0e9d7 into master Feb 5, 2024
@joe-allen-89 joe-allen-89 deleted the issue/295 branch February 5, 2024 11:10
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
@semantic-release-bot
Chore(release): 7.8.1 [skip ci]
fc0db7e 
## [7.8.1](v7.8.0...v7.8.1) (2024-02-05)

### Fix

* Keep active item position on save/restore (fixes #295) (#296) ([1c0e9d7](1c0e9d7)), closes [#295](#295) [#296](#296) [#295](#295)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

🎉 This PR is included in version 7.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current position is not restored
4 participants
@oliverfoster @joe-allen-89 @cahirodoherty-learningpool @lemmyadams