Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: move previous/next item count ARIA outside of title condition (fixes #293) #294

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Update: move previous/next item count ARIA outside of title condition (fixes #293) #294

merged 2 commits into from
Jan 11, 2024

Conversation

kirsty-hames
Copy link
Contributor

Including the item count e.g. "Item 1 of 3", in the .narrative__controls aria-label was dependant on the item having a title. Item count now reads regardless.

When _items[].title is set,.narrative__controls aria-label reads as "Back to item title (item 1 of 3)".

When _items[].title is not set,.narrative__controls aria-label reads as "Back (item 1 of 3)".

Fixes #293

@kirsty-hames kirsty-hames self-assigned this Jan 10, 2024
@kirsty-hames kirsty-hames changed the title Update: move previous/next item count aria outside of title condition (fixes #293) Update: move previous/next item count ARIA outside of title condition (fixes #293) Jan 10, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames mentioned this pull request Jan 11, 2024
Closed
joe-allen-89
joe-allen-89 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 3ab8e0d into master Jan 11, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/293 branch January 11, 2024 14:49
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
@semantic-release-bot
Chore(release): 7.8.0 [skip ci]
bba5e20 
# [7.8.0](v7.7.1...v7.8.0) (2024-01-11)

### Update

* move previous/next item count ARIA outside of title condition (fixes #293) (#294) ([3ab8e0d](3ab8e0d)), closes [#293](#293) [#294](#294)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previous / next button item count ARIA is dependant on title
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89