Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: isObjectId removed from schema to allow external assets to be added (fixes #309) #310

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix: isObjectId removed from schema to allow external assets to be added (fixes #309) #310

merged 1 commit into from
Dec 11, 2024

Conversation

joe-allen-89
Copy link
Contributor

#309

Fix

@joe-allen-89 joe-allen-89 self-assigned this Nov 8, 2024
@joe-allen-89 joe-allen-89 linked an issue Nov 8, 2024 that may be closed by this pull request
Unable to add external assets in V1. #309
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit c426d68 into master Dec 11, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@semantic-release-bot
Chore(release): 6.7.4 [skip ci]
e8b08fa 
## [6.7.4](v6.7.3...v6.7.4) (2024-12-11)

### Fix

* isObjectId removed from schema to allow external assets to be added (fixes #309) (#310) ([c426d68](c426d68)), closes [#309](#309) [#310](#310)
@oliverfoster oliverfoster deleted the issue/309 branch December 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug Ready to release
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add external assets in V1.
4 participants
@joe-allen-89 @oliverfoster @guywillis @cahirodoherty-learningpool