Fix: Firefox fullscreen api (fixes #239)

[oliverfoster]

fiex #239

Fix

• Firefox uses native fullscreen api where available

[cahirodoherty-learningpool]

👀

[joe-allen-89]

Tested with Firefox, Chrome and Edge, all working as expected.

[swashbuck]

I'm getting a console error when in fullscreen and pressing the ESC key to exit fullscreen.

Uncaught (in promise) TypeError: Not in fullscreen mode
    cancelFullScreen mediaView.js:103
    exitFullScreen mediaelement-and-player.js:4674
    fullscreenChanged mediaelement-and-player.js:4346

Environment

• Firefox 112.0.1
• Mac 11.7.6

Branches / versions

• Framework 5.28.9
• Media issue/239

[oliverfoster]

Cool. Will check on mac. Thanks.

[StuartNicholls]

@oliverfoster on Mac I'm not seeing it go in to Full screen, the vid increases to the browser size but the browser remains at the size before pressing the button. I also get the same console error

Uncaught (in promise) TypeError: Not in fullscreen mode

[oliverfoster]

Cool. Same as Brad's diagnosis. Ta. Which version of Safari? (Just in case).

[StuartNicholls]

Cool. Same as Brad's diagnosis. Ta. Which version of Safari? (Just in case).

Oh sorry, I always run the latest versions. Firefox 113.0.1

[oliverfoster]

• Firefox, obvs, I meant 🔥🦊

[swashbuck]

Commit adc38ab works for me. I no longer see TypeError: Not in fullscreen mode in Firefox (Mac) when exiting fullscreen mode. Needs some testing, though.

[joe-allen-89]

👍 tested with multiple browsers all working as expected, no errors.

[cahirodoherty-learningpool]

👀

[kirsty-hames]

Works as expected testing on Mac FF

[github-actions]

🎉 This PR is included in version 6.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀