-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid properties in properties.schema #10
Comments
no I think this is correct - it's annoying duplication but necessary due to course.json not having been loaded by the time the languagePicker is displayed We probably need to have a think about redoing the json load order... or maybe moving this sort of thing to a separate file like labels.json or strings.json |
That makes sense -- thanks for clarifying. I guess if those particular strings lived in config.json it wouldn't be a problem? |
that would solve for languagePicker text but wouldn't help for other things e.g. adaptlearning/adapt_framework#1238 |
There is an error in the properties.schema however - on line 69 the 'default' is set to |
@moloko fixed |
Possibly a copy and paste error, but there appears to be a few accessibility properties that don't really belong in the Language Picker extension here:
https://github.com/adaptlearning/adapt-contrib-languagePicker/blob/master/properties.schema#L130-L186
The text was updated successfully, but these errors were encountered: