Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid properties in properties.schema #10

Closed
brian-learningpool opened this issue Sep 26, 2016 · 5 comments
Closed

Invalid properties in properties.schema #10

brian-learningpool opened this issue Sep 26, 2016 · 5 comments

Comments

@brian-learningpool
Copy link
Member

Possibly a copy and paste error, but there appears to be a few accessibility properties that don't really belong in the Language Picker extension here:
https://github.com/adaptlearning/adapt-contrib-languagePicker/blob/master/properties.schema#L130-L186

@moloko
Copy link
Contributor

moloko commented Sep 26, 2016

no I think this is correct - it's annoying duplication but necessary due to course.json not having been loaded by the time the languagePicker is displayed

We probably need to have a think about redoing the json load order... or maybe moving this sort of thing to a separate file like labels.json or strings.json

@brian-learningpool
Copy link
Member Author

That makes sense -- thanks for clarifying. I guess if those particular strings lived in config.json it wouldn't be a problem?

@moloko
Copy link
Contributor

moloko commented Sep 26, 2016

that would solve for languagePicker text but wouldn't help for other things e.g. adaptlearning/adapt_framework#1238

@moloko
Copy link
Contributor

moloko commented Sep 26, 2016

There is an error in the properties.schema however - on line 69 the 'default' is set to "en" but this is not one of the allowed values, it should be "ltr"

@lc-thomasberger
Copy link
Member

@moloko fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants