Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add _isA11yCompletionDescriptionEnabled to schema and remove legacy _disableAccessibilityState (fixes #246) #460

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Oct 25, 2023

  • Replace legacy _disableAccessibleState with _isA11yCompletionDescriptionEnabled in component schemas.
  • Remove reference to legacy _disableAccessibilityState.
  • Add missing _isA11yCompletionDescriptionEnabled to schemas.

Fixes #246

Wiki updated in advance - _isA11yCompletionDescriptionEnabled added to the relevant models.

@kirsty-hames kirsty-hames self-assigned this Oct 25, 2023
@kirsty-hames kirsty-hames added accessibility bug Something isn't working labels Oct 25, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit dfc4208 into master Oct 27, 2023
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/246 branch October 27, 2023 09:20
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
## [6.41.3](v6.41.2...v6.41.3) (2023-10-27)

### Fix

* Add _isA11yCompletionDescriptionEnabled to schema and remove legacy _disableAccessibilityState (fixes #246) (#460) ([dfc4208](dfc4208)), closes [#246](#246) [#460](#460)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

henrietta-k pushed a commit to henrietta-k/adapt-learning-wiki that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add _isA11yCompletionDescriptionEnabled to schema
4 participants