From 8b78fc1619fc1f2fcb4c0bdd93d4e6afba033382 Mon Sep 17 00:00:00 2001 From: cahirodoherty-learningpool Date: Wed, 16 Nov 2022 13:15:02 +0000 Subject: [PATCH 1/5] Fix: postRender automatically setting blank component as completed --- js/blankView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/blankView.js b/js/blankView.js index 9b81878..1ef11cb 100644 --- a/js/blankView.js +++ b/js/blankView.js @@ -8,7 +8,7 @@ export default class BlankView extends ComponentView { postRender() { this.setReadyStatus(); - this.setupInviewCompletion(); + this.setCompletionStatus(); } } From ea62f60272ce55b234e1544c6f02b7b7f376d762 Mon Sep 17 00:00:00 2001 From: cahirodoherty-learningpool Date: Wed, 16 Nov 2022 13:18:06 +0000 Subject: [PATCH 2/5] Typo fix --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 750a692..f641119 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ * A sentence describing each fix ### Update -* A sentence describing each udpate +* A sentence describing each update ### New * A sentence describing each new feature From fc10f9ae94f1fb2568ff1820e295034276ec433c Mon Sep 17 00:00:00 2001 From: cahirodoherty-learningpool Date: Tue, 6 Dec 2022 11:47:05 +0000 Subject: [PATCH 3/5] Override the _isOptional default setting for the component --- properties.schema | 7 ++++++- schema/component.schema.json | 9 +++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/properties.schema b/properties.schema index 3843913..63733cc 100644 --- a/properties.schema +++ b/properties.schema @@ -10,6 +10,11 @@ "enum": ["full-width", "half-width", "both"], "default": "both", "editorOnly": true - } + }, + "_isOptional": { + "type": "boolean", + "required": false, + "default": false + }, } } diff --git a/schema/component.schema.json b/schema/component.schema.json index 24dcc10..a0d9191 100644 --- a/schema/component.schema.json +++ b/schema/component.schema.json @@ -8,6 +8,15 @@ }, "with": { "properties": { + "_isOptional": { + "type": "boolean", + "default": true, + "isSetting": true, + "inputType": "Checkbox", + "validators": [], + "title": "Is this optional?", + "help": "An optional component does not have to be completed by the user." + }, "_supportedLayout": { "type": "string", "title": "Supported layout", From 0cd2f69eb47fdd0d062ff759db9f549d26418ee6 Mon Sep 17 00:00:00 2001 From: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com> Date: Mon, 9 Jan 2023 12:17:02 +0000 Subject: [PATCH 4/5] Update properties.schema Co-authored-by: Oliver Foster --- properties.schema | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/properties.schema b/properties.schema index 63733cc..997357e 100644 --- a/properties.schema +++ b/properties.schema @@ -14,7 +14,7 @@ "_isOptional": { "type": "boolean", "required": false, - "default": false + "default": true }, } } From ffbb3f5facc10c8615c70f9463be88982f444fad Mon Sep 17 00:00:00 2001 From: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com> Date: Mon, 9 Jan 2023 12:17:31 +0000 Subject: [PATCH 5/5] Update js/blankView.js Co-authored-by: Oliver Foster --- js/blankView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/blankView.js b/js/blankView.js index 1ef11cb..9b81878 100644 --- a/js/blankView.js +++ b/js/blankView.js @@ -8,7 +8,7 @@ export default class BlankView extends ComponentView { postRender() { this.setReadyStatus(); - this.setCompletionStatus(); + this.setupInviewCompletion(); } }