Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank components should always be marked as complete #45

Closed
cahirodoherty-learningpool opened this issue Nov 16, 2022 · 2 comments · Fixed by #46
Closed

Blank components should always be marked as complete #45

cahirodoherty-learningpool opened this issue Nov 16, 2022 · 2 comments · Fixed by #46

Comments

@cahirodoherty-learningpool
Copy link
Contributor

Subject of the issue/enhancement/features

To avoid course completion prevention when blank components are used, they should be marked as complete upon postRender on the page

Your environment

  • FW 5.X
  • Chrome
  • All devices

Steps to reproduce

Create a course with blank components and page level progress

Expected behaviour

PLP should fill immediately on page load. Clicking PLP will show blank components individually have completed

Actual behaviour

Course will never complete as Blank components do not get marked this way

@paulstevendev
Copy link

paulstevendev commented Nov 16, 2022

Surely the actual behaviour is the course will complete as the page containing just a blank component will record as complete when you open it then return to the menu. The only thing that I can see doesn't happen is the page level progress doesn't show the blank component as having completed but it makes no sense to include the blank component in the page level progress as the user cannot see the blank components. For our particular use to detect a page has opened we only require one NOT optional blank component at the top of the page.

@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jan 16, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 4.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants