Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rather than hijack existing code, provide its own <Link>? #1

Closed
gaearon opened this issue Nov 5, 2015 · 2 comments
Closed

Rather than hijack existing code, provide its own <Link>? #1

gaearon opened this issue Nov 5, 2015 · 2 comments

Comments

@gaearon
Copy link

gaearon commented Nov 5, 2015

As discussed in remix-run/react-router#1840, the intent was to let the user wrap a <Link> component instead of “fixing” it by monkeypatching React Router.

What do you think about exporting your own <Link> component that uses React Router's <Link> under the hood? This would remove the need for monkeypatching.

@adamziel
Copy link
Owner

adamziel commented Nov 5, 2015

Good idea! I will add it as an alternative so user can start with monkeypatching and use the custom component when there is more time for refactoring

@adamziel
Copy link
Owner

adamziel commented Nov 5, 2015

Resolved in aae6e80 plus I added some tests in later commits

@adamziel adamziel closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants