Only revision existing metadata #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @aaemnnosttv thank you for the PR, the is excellent! My only concern here would be to ensure the revisioned meta matches the post state, previously I had tried getting the meta and found issues with that (described here #32 (comment)). I feel like using Before merging I'd like to test this with storing blank and false values to meta, to make sure those values are still revisioned. It would be great to get test coverage for that as well. |
# Conflicts: # tests/test-meta-revisions.php # wp-post-meta-revisions.php
# Conflicts: # tests/test-meta-revisions.php # wp-post-meta-revisions.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic for meta which is created on the revision.
Currently, a post meta entry is created for every revisioned meta key, whether it exists or not.
This adds a simple check to see if the meta exists first and only creates an entry on the revision if it does.
Also included are updates to the test case to cover this change as well as a few enhancements to the test case itself:
Resolves #32