Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set auto-increment to patch in the command-line tool when the env var is set to something else #665

Closed
adamralph opened this issue Feb 1, 2022 · 2 comments · Fixed by #667
Closed

Cannot set auto-increment to patch in the command-line tool when the env var is set to something else #665

adamralph opened this issue Feb 1, 2022 · 2 comments · Fixed by #667
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@adamralph
Copy link
Owner

Version(s)

  • 2.4.0
  • 2.5.0

To reproduce

Steps to reproduce the behaviour:

  1. Create an empty git repo
  2. Make a commit
  3. Tag the commit 1.0.0
  4. Make another commit
  5. Set the MinVerAutoIncrement env var to Minor (or Major)
  6. Run minver with --auto-increment patch

Expected behaviour

The calculated version is 1.0.1-alpha.0.1.

Actual behaviour

The calculated version is 1.1.0-alpha.0.1 (or 2.0.0-alpha.0.1 if the MinVerAutoIncrement env var is set to Major).

Workarounds

Unset the MinVerAutoIncrement instead of overriding it with --auto-increment patch.

Additional context

n/a
@adamralph adamralph added the bug Something isn't working label Feb 1, 2022
@adamralph adamralph added this to the 3.0.0 milestone Feb 1, 2022
@adamralph adamralph linked a pull request Feb 1, 2022 that will close this issue
fix null usage #658
Merged
@adamralph adamralph removed a link to a pull request Feb 1, 2022
fix null usage #658
Merged
@adamralph adamralph linked a pull request Feb 1, 2022 that will close this issue
fix null usage #667
Merged
@adamralph
Copy link
Owner Author

fixed in #667

@adamralph
Copy link
Owner Author

released in 3.0.0-rc.2

@adamralph adamralph changed the title Cannot set auto-increment to patch in the CLI tool when the env var is set to something else Cannot set auto-increment to patch in the command-line tool when the env var is set to something else Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

fix null usage adamralph/minver
1 participant
@adamralph