Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifying locale from URL fails when permalink is set to false #10

Closed
arkhi opened this issue Feb 24, 2021 · 2 comments
Closed

Identifying locale from URL fails when permalink is set to false #10

arkhi opened this issue Feb 24, 2021 · 2 comments

Comments

@arkhi
Copy link

arkhi commented Feb 24, 2021

I was originally going to submit a PR, but since there are already 3 waiting, I decided to first open this issue.

Eleventy allows to specify permalink: false to not generate a page for specific templates.

This results in the error TypeError: url.split is not a function because false.split is problematic.

I think #5 actually solves this issue.

@arkhi
Copy link
Author

arkhi commented Feb 24, 2021

😇 Duplicate of #4.

@arkhi arkhi closed this as completed Feb 24, 2021
@adamduncan
Copy link
Owner

Thanks @arkhi. There's a bit of extra functionality covered in #4 that we're not quite 100% on.

I think likely we'll get in a dedicated permalink: false fix as a patch release. Thanks for reminding me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants