Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using DjangoJSONEncoder in json.dumps #180

Closed
CleitonDeLima opened this issue Jan 7, 2022 · 2 comments · Fixed by #182
Closed

Using DjangoJSONEncoder in json.dumps #180

CleitonDeLima opened this issue Jan 7, 2022 · 2 comments · Fixed by #182

Comments

@CleitonDeLima
Copy link
Contributor

CleitonDeLima commented Jan 7, 2022 •
edited
Loading

Description

Hi,

It might be interesting to use DjangoJSONEncoder when dumping a dict in trigger_client_event.

django-htmx/src/django_htmx/http.py

Line 63 in 825e349

response[header] = json.dumps(data) 

response[header] = json.dumps(data, cls=DjangoJSONEncoder)
@adamchainz
Copy link
Owner

It might be interesting

I guess it would make sense to fit in with Django, but do you have a use case?

Feel free to open a PR. Please do add a test and changelog note.

@CleitonDeLima CleitonDeLima mentioned this issue Jan 10, 2022
Merged
@CleitonDeLima
Copy link
Contributor Author

I guess it would make sense to fit in with Django, but do you have a use case?

Shen it is necessary to serialize data of type date or decimal, which json.dumps does not support, DjangoJSONEncoder can help in these cases.

I did a PR with a test of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed json cls encoder in trigger_client_event CleitonDeLima/django-htmx
2 participants
@adamchainz @CleitonDeLima