Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we open to PR that improves helptext module? #212

Open
wayneyaoo opened this issue Jan 18, 2022 · 4 comments
Open

Are we open to PR that improves helptext module? #212

wayneyaoo opened this issue Jan 18, 2022 · 4 comments
Assignees
Labels
concept Help and further investigation on the proposal is needed. Typin Typin library related issues
Milestone

Comments

@wayneyaoo
Copy link

Is your feature request related to a problem? Please describe.
I'm looking at the IHelpWriter and the default implementation of DefaultHelpWriter. Though the project claims to support "customized helptext", which it does, I found it still a bit cumbersome to implement self-defined helptext writer, mainly because the help writer does not allow configuration via e.g., IHelpWriterConfiguration. If I need to change only a bit of the helptext, I had to copy the whole DefaultHelpWriter and update only a few lines.

Describe the solution you'd like
I'm very happy to make the help writer a small but nicely constructed component/module to at least allow configuration. e.g., new lines between sections or not, option alignment etc. The granularity can be discussed but my question is, is such change blessed?

@wayneyaoo wayneyaoo added the concept Help and further investigation on the proposal is needed. label Jan 18, 2022
@adambajguz
Copy link
Owner

adambajguz commented Jan 19, 2022

Hi @wayneyaoo ,
to be honest I was also thinking about building new help system but for Typin 4.0 that will be more extensible. Typin 4.0 is currently 'in development' on branch 'feature/generic-host', and new help writer was planned to be a Typin Plugin. Your help will be appreciated!

@adambajguz adambajguz added this to the v4.0 milestone Jan 19, 2022
@adambajguz adambajguz added the Typin Typin library related issues label Jan 19, 2022
@wayneyaoo
Copy link
Author

Thank you for the confirmation. If I'm about to write code, should I PR to that the "in development" branch?

@adambajguz
Copy link
Owner

adambajguz commented Jan 20, 2022

I think we can try implementing from master branch, so it can be released as Typin 3.2 before Typin 4.0. Only data access layer of help will change in Typin 4.0 but help components, sections, headers, etc. should be the same. Please treat IHelpWriter methods as an entry point for new component-based help - not to introduce changes in existing interfaces and only add new.

@wayneyaoo
Copy link
Author

I'll come back with a PR :) Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Help and further investigation on the proposal is needed. Typin Typin library related issues
Projects
None yet
Development

No branches or pull requests

2 participants