Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Abstract DiscreteSpaceDF #30

Merged
merged 26 commits into from
Jul 23, 2024
Merged

Adding Abstract DiscreteSpaceDF #30

merged 26 commits into from
Jul 23, 2024

Conversation

adamamer20
Copy link
Collaborator

@adamamer20 adamamer20 commented Jul 20, 2024 •
edited
Loading

This PR adds an abstract class to define the interface for Discrete Spaces (Grids and Networks).

Some points to consider:

  • A default capacity can be set in the __init__, which can be overriden by a capacity set in set_cells. There might be some performance benefits if only a default capacity was allowed (I think we can consider changing it after we have the concrete implementation)
  • Distinction between "empty" and "free" cells. Empty cells are cells were no agent is currently present, free cells are cells where some agents may be present but there is some remaining capacity.

adamamer20 and others added 25 commits July 9, 2024 11:29
@adamamer20
addind conversion to geobjects
f3c2f43
@adamamer20
Merge branch 'main' into 6-refactoring-mesaspace
a50003f
@adamamer20
change from types to types_ to avoid import issues
9c2b281
@adamamer20
creation of DataFrameMixin
9546b10
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a716118 
for more information, see https://pre-commit.ci
@adamamer20
Abstract Space and GridDF
b181c8b
@adamamer20
Merge branch 'dataframe-mixin' of https://github.com/adamamer20/mesa-…
2e94a38 
…frames into 6-refactoring-mesaspace
@adamamer20
removing space types (has it's own PR)
a9c9925
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cecf5af 
for more information, see https://pre-commit.ci
@adamamer20
update space types
3d72461
@adamamer20
update types with types_
4722edb
@adamamer20
Moved agentset to library folder
21c5ef8
@adamamer20
update __init__
831324a
@adamamer20
remove geopandas
853a19e
@adamamer20
removed gpd
7d128a8
@adamamer20
Merge branch 'main' into dataframe-mixin
783a717
@adamamer20
Merge branch 'dataframe-mixin' of https://github.com/adamamer20/mesa-…
4fdcd98 
…frames into 6-refactoring-mesaspace
@adamamer20
Merge 'main'
0d37506
@adamamer20
merge fix
81fce01
@adamamer20
moved space to abstract and concrete
0f87a51
@adamamer20
fixed typing
d90544d
@adamamer20
Merge branch 'main' into abstract-discrete-space
ab13e35
@adamamer20
refining discretespacedf
48d3306
@adamamer20
Removing lru_cache
d01c427
@adamamer20
Removing concrete pandas, polars implementation
7bb5b11
@adamamer20 adamamer20 requested a review from rht July 20, 2024 09:19
@adamamer20 adamamer20 self-assigned this Jul 20, 2024
@adamamer20 adamamer20 added the enhancement Improvements to existing features or performance. label Jul 20, 2024
@adamamer20 adamamer20 added this to the 1.0.0 Alpha Release milestone Jul 20, 2024
rht
rht reviewed Jul 21, 2024
View reviewed changes
mesa_frames/abstract/space.py Outdated Show resolved Hide resolved
rht
rht reviewed Jul 21, 2024
View reviewed changes
mesa_frames/abstract/space.py Outdated Show resolved Hide resolved
@adamamer20 adamamer20 changed the title Adding DiscreteSpaceDF Adding Abstract DiscreteSpaceDF Jul 21, 2024
@adamamer20
Copy link
Collaborator Author

Sorry for the delay, I've been a bit busy the last few days

@rht rht merged commit e5f9802 into main Jul 23, 2024
6 checks passed
@rht rht deleted the abstract-discrete-space branch July 23, 2024 08:35
This was linked to issues Jul 24, 2024
Refactoring mesa.space #6
Open
Abstract DiscreteSpaceDF #40
Closed
@adamamer20 adamamer20 restored the abstract-discrete-space branch July 24, 2024 10:54
@adamamer20 adamamer20 deleted the abstract-discrete-space branch July 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht approved these changes

Assignees

@adamamer20 adamamer20

Labels
enhancement Improvements to existing features or performance.
Projects
None yet
Milestone
0.1.0 Alpha Release
Development

Successfully merging this pull request may close these issues.

Refactoring mesa.space Abstract DiscreteSpaceDF
2 participants
@adamamer20 @rht