Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vim.ui.select as a picker #107

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

Bleksak
Copy link
Contributor

@Bleksak Bleksak commented Oct 10, 2024

Hi, this is a PR to support vim.ui.select as a picker.
Later I will add support for fzf too

It works, but It's not switchable via config, you need to manually toggle it in default providers.
How would you want me to resolve this?

It would be great if we could add "picker" into configuration, however I don't see a way to do it now.

@adalessa
Copy link
Owner

adalessa commented Oct 11, 2024

Thanks looks good, but I think there is duplication with the action between the pickers, I think adding this could be a good moment to extract them if they can be re-use.

I meant these two:
lua/laravel/ui_select/actions.lua
lua/laravel/ui_select/ui_run.lua

@adalessa
Copy link
Owner

It works, but It's not switchable via config, you need to manually toggle it in default providers.
How would you want me to resolve this?
It would be great if we could add "picker" into configuration, however I don't see a way to do it now.

Let me think about this and will get back to you on this.

@adalessa
Copy link
Owner

@Bleksak I have pushed a change to the branch that handles the configuration aspect of it. pls check it, if you have a question let me know.

@Bleksak
Copy link
Contributor Author

Bleksak commented Oct 12, 2024

@adalessa Thanks, I sucessfully integrated it and fixed the duplication issues. Can you check it now?

@adalessa adalessa merged commit b3df825 into adalessa:development Oct 12, 2024
@adalessa
Copy link
Owner

Thanks for the collaboration, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants