Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show diffs introduced by running pre-commit (especially black) #34

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Show diffs introduced by running pre-commit (especially black) #34

merged 6 commits into from
Jan 30, 2024

Conversation

jepler
Copy link
Member

@jepler jepler commented Jan 21, 2024

No description provided.

@jepler jepler requested a review from tekktrik January 21, 2024 17:02
@jepler jepler mentioned this pull request Jan 21, 2024
Open
tekktrik
tekktrik previously requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change for pre-commit, as well as the package prefix fix (fix fix)!

Just one typo but otherwise good to go!

build/action.yml Outdated Show resolved Hide resolved
@tekktrik
Copy link
Member

I do know the failure help CI isn't working as intended still so I'll patch that up in its repo, and is outside the scope of this PR.

@tekktrik tekktrik dismissed their stale review January 30, 2024 20:36

Changes made

tekktrik
tekktrik approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Went ahead and fixed the merge conflicts as well as the typos.

@tekktrik tekktrik merged commit a2d4368 into main Jan 30, 2024
2 checks passed
@jepler
Copy link
Member Author

jepler commented Jan 31, 2024

Thanks @tekktrik !

@jepler jepler deleted the black-show-diff branch January 31, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @tekktrik