circuitpython_stubs: Use circuitpython_typing for cp-specific typing
#5760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For interest, I am kind of surprised python/typing#593 is still an open issue. |
Installing stubs for a module named `_typing` seems like a dubious decision.
These diagnostics occurred, but weren't treated as errors: ``` [WARN] Missing return type: alphablend on line 38 [WARN] Missing argument type: dest_bitmap on line 38 [WARN] Missing argument type: source_bitmap_1 on line 38 [WARN] Missing argument type: source_bitmap_2 on line 38 ```
jepler
force-pushed
the
rename_under_typing
branch
from
b7acaed to
fb79d1c
Compare
note that per the https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python specify "3" for the latest python version (not 3.x as on github actions)
|
This also bumps sphinx to current versions so that it should work with 3.10 |
hathach
pushed a commit
to hathach/circuitpython
that referenced
this pull request
Dec 23, 2021
Commit 4173950 removed automatic building of mpy-cross, which rebuilt it whenever any of its dependent source files changed. But needing to build mpy-cross, and not knowing how, is a frequent issue. This commit aims to help by automatically building mpy-cross only if it doesn't exist. For Makefiles it uses an order-only prerequisite, while for CMake it uses a custom command. If MICROPY_MPYCROSS (which is what makemanifest.py uses to locate the mpy-cross executable) is defined in the environment then automatic build will not be attempted, allowing a way to prevent this auto-build if needed. Thanks to Trammell Hudson aka @osresearch for the original idea; see adafruit#5760. Signed-off-by: Damien George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing stubs for a module named
_typingseems like it may create problems in the future, but this name should be much safer.