Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the TinyUSB library? #322

Closed
Spegs21 opened this issue Jan 28, 2022 · 2 comments
Closed

Update the TinyUSB library? #322

Spegs21 opened this issue Jan 28, 2022 · 2 comments
Assignees
@hathach

Comments

@Spegs21
Copy link

Spegs21 commented Jan 28, 2022

Can we update the TinyUSB library included in the core? The newer revs have TinyUSBDevice.setSerialDescriptor() which I need for my TinyUSB implementation here: Legion2/CorsairLightingProtocol#215

I'm happy to create the PR if needed.
@hathach
Copy link
Member

hathach commented Jan 29, 2022

we will do it gradually, BSP has longer release cycle than library. Meanwhile you could just install TinyUSB from library manager, it will be picked by arduino instead of the one in the core.

@Spegs21
Copy link
Author

Spegs21 commented Jan 29, 2022

@hathach I reverted the core version on my local install and installed the library from library manager and it worked as you described. I thought I tried this earlier and it didn't work but it must have been an issue with my implementation. Thanks for looking into it.

@Spegs21 Spegs21 closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hathach hathach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hathach @Spegs21