Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: non-blocking play_file() #18

Open
PaintYourDragon opened this issue Aug 2, 2021 · 1 comment
Open

Feature request: non-blocking play_file() #18

PaintYourDragon opened this issue Aug 2, 2021 · 1 comment

Comments

@PaintYourDragon
Copy link

Maybe an optional boolean argument whether to block on WAV playback or not? Would want corresponding function(s) to poll whether currently playing and to disable speaker without accessing protected elements.

Currently working around this with a few extra lines in the Dragon Drop game:
https://github.com/adafruit/Adafruit_Learning_System_Guides/tree/main/Macropad_Dragon_Drop
Not a pressing need, the workaround’s simple enough, just that it might make user-facing code less daunting by not having pylint directives in there and stuff. Thx.

@kattni
Copy link
Contributor

kattni commented Aug 5, 2021

Hey, @PaintYourDragon. Thanks for filing this issue. At the moment, wav playback is still not working properly on RP2040 (and maybe others, I'm not certain). Either way, if I make it non-blocking at the moment, it will cause issues. Dan's working on getting it fixed, and once that fix is sorted, I will update the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants