Update read_reg() to use repeated start #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #37.
Basically just switches to using a repeated start in the
read_reg()
function.All of the I2C examples in the MLX90393 datasheet show repeated start. The MLX90393 seems to be somewhat OK with a stop/start split write/read transaction, since that is used in a few places. But that mixed with the additional I2C overhead dealing with setting the muxer does not seem to work (see traces in issue thread).
Tested with QT PY RP2040 + PCA9546A + MLX90393, the same setup that was failing before, works now:
And still works without the muxer and simply connected directly: