Add Missing Type Annotations - Partial #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you intend to keep it all in this one review, or break it up across multiple PRs? If it's the latter, I'll unlink the issue so it doesn't get lost or forgotten. :) |
|
I guess I anticipated feedback on the others that would require correction, and that I’d gety the last file annotated and completed with the rest. There were pretty lot hanging fruit, so if that’s not the case, unlink the or and I’ll push the last when I get it done. I won’t get to it before this evening, at the earliest. |
FoamyGuy
reviewed
May 22, 2023
|
Thank you @FoamyGuy . I've been dragging my feet, I know. I'll be out of town for two weeks. I'll try to wrap this up when I get back. |
FoamyGuy
approved these changes
Nov 19, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 20, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#32 from FoamyGuy/blinka_warning Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#35 from FoamyGuy/type_annotations > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#29 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #18
This is a PARTIALLY COMPLETE solution - still completing work on objects and methods in emc2101_fanspeed.py....Wanted to get the others (init.py, emc2101_lut.py, emc2101_ext.py, and emc2101_enums.py) up for feedback and review.