Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings in bitmap_label #171

Open
Neradoc opened this issue May 12, 2022 · 1 comment
Open

Suppress warnings in bitmap_label #171

Neradoc opened this issue May 12, 2022 · 1 comment

Comments

@Neradoc
Copy link
Contributor

Neradoc commented May 12, 2022

There are warnings printed in bitmap_label (but not label), if a glyph is missing, and if a glyph is clipped.
Those generate possibly unwanted "noise" to the REPL, it would be nice to silence them.

But I don't know if we'll want to: remove them or have an option to silence them or an option to display them, and if so, we likely want it to work on both types of labels.

@jposada202020
Copy link
Contributor

I think that we could do something similar to this

https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout/blob/64b75e12e56d5518aa662dce35711e36ce031856/adafruit_displayio_layout/widgets/cartesian.py#L80

Normally you would not find any trouble with the glyphs as the ascender/descender will be pretty standard across the letters , there are some exceptions fonts , and with the work done in #103 it was helpful for debugging/information purposes.

Depending on the font, there could be glyphs that are not present, this is more prevalent for not common characters, so it is to inform the user that the character that they want to display is not present in the font file.

all that to say that I am in favor of using the Verbose argument :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants