Rotation fix #24
Merged
Rotation fix #24
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Nov 20, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 21, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.16 from 5.4.15: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#126 from FoamyGuy/config_mode_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 4.0.6 from 4.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#102 from FoamyGuy/dht11_decimal Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.7.2 from 1.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#24 from FoamyGuy/rotation_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.2.14 from 2.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#67 from FoamyGuy/rpi_example_comment Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.18 from 2.2.17: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#56 from FoamyGuy/setsysparam_sleep Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #23
This offset being applied only during init means all subsequent rotation setting was off by 90 compared to the initial rotation. I tried overriding the property setter to apply the offset, but had no luck with that. Then it occurred to me to just remove the offset altogether and change the default rotation argument to 90. This way subsequent setting matches as expected, and the default behavior remains landscape on the OLED Featherwing.
I tested successfully with https://www.adafruit.com/product/4650 that reproducer from the issue no longer has the unexpected rotation behavior, and that all 128x64 examples are showing the correct orientation.