Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible type bugs for wire types in AdafruitSensorMeasurement #7

Open
kevinjwalters opened this issue May 14, 2020 · 0 comments
Open

Possible type bugs for wire types in AdafruitSensorMeasurement #7

kevinjwalters opened this issue May 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@kevinjwalters
Copy link

Comparing

Adafruit_CircuitPython_BLE_BroadcastNet/adafruit_ble_broadcastnet.py

Line 129 in c6328d5

color = ManufacturerDataField(0x0A0E, "<f")
with https://circuitpython.readthedocs.io/en/5.0.x/docs/design_guide.html#sensor-properties-and-units there are a few type mismatches:

  • color - f vs int (32bit is used in AdafruitColor())
  • duty_cycle - f vs int (16bit int?)
  • frequency - f vs int
  • value - f vs a "union" of int (16 bit) /bool
@kevinjwalters kevinjwalters changed the title Possible type bugs Possible type bugs for wire types in AdafruitSensorMeasurement May 14, 2020
@evaherrada evaherrada added the bug Something isn't working label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinjwalters @evaherrada