Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-eli-git] need to build with c++11 #37

Open
petronny opened this issue May 17, 2020 · 3 comments
Open

[code-eli-git] need to build with c++11 #37

petronny opened this issue May 17, 2020 · 3 comments

Comments

@petronny
Copy link

Building with gcc raises:

[ 46%] Building CXX object test/geom/piecewise_surface/CMakeFiles/PiecewiseSurfaceCreatorTest.dir/piecewise_surface_creator_test.cpp.o
[ 48%] Building CXX object test/geom/minimum_distance/CMakeFiles/MinimumDistanceTest.dir/minimum_distance_test.cpp.o
[ 50%] Building CXX object test/geom/pseudo_curve/CMakeFiles/PolynomialCurveTest.dir/polynomial_curve_test.cpp.o
In file included from /build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_test.cpp:28:
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4329:17: warning: use
   of C++17 hexadecimal floating constant
 4329 |           pt << 0x1.001391762278p-2, -0x1.8951f245bb4f1p-9, 0x1.00093dc6b03
c1p-3;
      |                 ^~~~~~~~~~~~~~~~~
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4329:17: error: exponent
   has no digits
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4329:39: warning: use
   of C++17 hexadecimal floating constant
 4329 |           pt << 0x1.001391762278p-2, -0x1.8951f245bb4f1p-9, 0x1.00093dc6b03
c1p-3;
      |                                       ^~~~~~~~~~~~~~~~~~
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4329:39: error: exponent
   has no digits
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4329:61: warning: use
   of C++17 hexadecimal floating constant
 4329 |           pt << 0x1.001391762278p-2, -0x1.8951f245bb4f1p-9, 0x1.00093dc6b03c1p
-3;
      |                                                             ^~~~~~~~~~~~~~~~~~

/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4329:61: error: exponent
   has no digits
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4331:17: warning: use
   of C++17 hexadecimal floating constant
 4331 |           pt << 0x1.0014bcf3232b4p-2, -0x1.76b17b575fa2ep-9, 0x1.000b94c0b1
a28p-3;
      |                 ^~~~~~~~~~~~~~~~~~
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4331:17: error: exponent
   has no digits
/build/code-eli-git/src/Code-Eli/test/geom/minimum_distance/minimum_distance_surface_test_suite.hpp:4331:40: warning: use
   of C++17 hexadecimal floating constant
 4331 |           pt << 0x1.0014bcf3232b4p-2, -0x1.76b17b575fa2ep-9, 0x1.000b94c0b1
a28p-3;
      |                                        ^~~~~~~~~~~~~~~~~~

Building with gcc8 is fine.

@acxz
Copy link
Owner

acxz commented May 17, 2020

thx for the report. yep can reproduce, linking this to upstream

@acxz
Copy link
Owner

acxz commented May 17, 2020

submitted a fix upstream, let's give it some time for the developer to see/merge it in so I dont have to patch it.

@acxz
Copy link
Owner

acxz commented Jun 2, 2020

Since it seems like upstream is not planning on fixing the issue anytime soon, I went ahead and patched it locally. Should be fixed now. @petronny let me know if there are other issues.

@acxz acxz closed this as completed Jun 2, 2020
@acxz acxz added the patched label Jan 28, 2022
@acxz acxz reopened this Jan 28, 2022
@acxz acxz changed the title [code-eli-git] Only build with gcc8 [code-eli-git] need to build with c++11 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants