-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current limit depends on macOS charging percentage, which is not accurate. #294
Comments
Since no one responded, I spent some time to solve it by myself by modifying battery.sh. The modifications include
|
Can you please share your modified version? |
@js4jiang5 Care to create a PR with your changes? |
I don't know how to PR, but I just checked current PR and found someone has been working on similar issue. |
Tried that, doesn’t work as expected. |
Could you describe what went wrong? |
Correction - it didn't work at all, if we talk about the same PR from user seefood. I don't remember the details, if you really need that info I could try again sometime this week. |
Yep, the PR from seefood. Please try again and let us know. |
@js4jiang5 % battery maintain 70-80 |
I actually managed to use the solution from seefood, but adding his code manually to current battery.sh version. I lost some functionalities on the way (like maintain voltage), just for the sake of easier debugging, I don't even need it. Maybe I'll try to merge them in a clean way, but I would like to see your solution too @js4jiang5 |
What is the issue? (required)
Current limit depends on macOS charging percentage, which differs from real hardware charging percentage by 1~7%.
What exactly did you do to produce the issue? (required)
I recorded the charging percentages of macOS and CoconutBattery.
I set "battery maintain 65".
When macOS dropped to 64% and triggered charging, CoconutBattery shows 60.1%. The difference is about 4%.
After battery is charged to macOS 66%, CoconutBattery shows 65.1%. The difference is about 1%.
The difference varies, depending on whether it's charging or discharging.
Expected behavior (required)
As Al dente pointed out that they use real hardware charging percentage instead of macOS percentage, it would be better for battery.app to do the same for better accuracy.
Additional context (optional)
I tried to use voltage to remedy this issue, but found that even using voltage has problems.
For example, if you set "battery maintain 11.4V 0.2V", you expect it to trigger charging at 11.2V and stop charging at 11.6V.
However, in reality, when the charging is triggered at 11.2V, it abruptly jumped to 12.2V due to charging.
The text was updated successfully, but these errors were encountered: