From 0085215000b39621fc9ba6661d629e960808740c Mon Sep 17 00:00:00 2001
From: iOSLife <developer@ioslife.dev>
Date: Thu, 16 Nov 2023 09:34:46 -0500
Subject: [PATCH 1/5] add filter to not include hidden categories when adding
 transaction

---
 .../src/components/autocomplete/CategoryAutocomplete.tsx        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
index 267b657ca1a..9c640491c9e 100644
--- a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
+++ b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
@@ -46,7 +46,7 @@ function CategoryList({
           ...(!embedded && { maxHeight: 175 }),
         }}
       >
-        {items.map((item, idx) => {
+        {items.filter(item => !item.hidden).map((item, idx) => {
           if (item.id === 'split') {
             return (
               <View

From 60bc0e85603e7ee90862e96d66f65cea9f760298 Mon Sep 17 00:00:00 2001
From: iOSLife <developer@ioslife.dev>
Date: Thu, 16 Nov 2023 09:42:13 -0500
Subject: [PATCH 2/5] adding release notes

---
 upcoming-release-notes/1914.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 upcoming-release-notes/1914.md

diff --git a/upcoming-release-notes/1914.md b/upcoming-release-notes/1914.md
new file mode 100644
index 00000000000..b96074f6663
--- /dev/null
+++ b/upcoming-release-notes/1914.md
@@ -0,0 +1,6 @@
+---
+category: Features
+authors: iOSLife
+---
+
+Adds a filter on the item list in the CategoryAutocomplete component. This will prevent users from accidentally adding a transaction to a hidden category.
\ No newline at end of file

From c0171dabc0158692ce176966e6024002cc945077 Mon Sep 17 00:00:00 2001
From: iOSLife <developer@ioslife.dev>
Date: Thu, 16 Nov 2023 09:47:21 -0500
Subject: [PATCH 3/5] addressing linting failure

---
 .../src/components/autocomplete/CategoryAutocomplete.tsx       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
index 9c640491c9e..b588ed4fb3a 100644
--- a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
+++ b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
@@ -46,7 +46,8 @@ function CategoryList({
           ...(!embedded && { maxHeight: 175 }),
         }}
       >
-        {items.filter(item => !item.hidden).map((item, idx) => {
+        {items.filter(item => !item.hidden)
+              .map((item, idx) => {
           if (item.id === 'split') {
             return (
               <View

From 849a3ee2fd60bca2a4f18e22df14c0f4565202e0 Mon Sep 17 00:00:00 2001
From: iOSLife <developer@ioslife.dev>
Date: Thu, 16 Nov 2023 09:47:26 -0500
Subject: [PATCH 4/5] making authors a list

---
 upcoming-release-notes/1914.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/upcoming-release-notes/1914.md b/upcoming-release-notes/1914.md
index b96074f6663..f8a9d0f20b7 100644
--- a/upcoming-release-notes/1914.md
+++ b/upcoming-release-notes/1914.md
@@ -1,6 +1,6 @@
 ---
 category: Features
-authors: iOSLife
+authors: [iOSLife]
 ---
 
 Adds a filter on the item list in the CategoryAutocomplete component. This will prevent users from accidentally adding a transaction to a hidden category.
\ No newline at end of file

From e18fd5cc19cd84f7b0362f4371b6787b8b64c86a Mon Sep 17 00:00:00 2001
From: iOSLife <developer@ioslife.dev>
Date: Thu, 16 Nov 2023 09:50:54 -0500
Subject: [PATCH 5/5] running yarn eslint --fix

---
 .../autocomplete/CategoryAutocomplete.tsx     | 183 +++++++++---------
 1 file changed, 92 insertions(+), 91 deletions(-)

diff --git a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
index b588ed4fb3a..9ab486b8350 100644
--- a/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
+++ b/packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx
@@ -46,103 +46,104 @@ function CategoryList({
           ...(!embedded && { maxHeight: 175 }),
         }}
       >
-        {items.filter(item => !item.hidden)
-              .map((item, idx) => {
-          if (item.id === 'split') {
-            return (
-              <View
-                key="split"
-                {...(getItemProps ? getItemProps({ item }) : null)}
-                // Downshift calls `setTimeout(..., 250)` in the `onMouseMove`
-                // event handler they set on this element. When this code runs
-                // in WebKit on touch-enabled devices, taps on this element end
-                // up not triggering the `onClick` event (and therefore delaying
-                // response to user input) until after the `setTimeout` callback
-                // finishes executing. This is caused by content observation code
-                // that implements various strategies to prevent the user from
-                // accidentally clicking content that changed as a result of code
-                // run in the `onMouseMove` event.
-                //
-                // Long story short, we don't want any delay here between the user
-                // tapping and the resulting action being performed. It turns out
-                // there's some "fast path" logic that can be triggered in various
-                // ways to force WebKit to bail on the content observation process.
-                // One of those ways is setting `role="button"` (or a number of
-                // other aria roles) on the element, which is what we're doing here.
-                //
-                // ref:
-                // * https://github.com/WebKit/WebKit/blob/447d90b0c52b2951a69df78f06bb5e6b10262f4b/LayoutTests/fast/events/touch/ios/content-observation/400ms-hover-intent.html
-                // * https://github.com/WebKit/WebKit/blob/58956cf59ba01267644b5e8fe766efa7aa6f0c5c/Source/WebCore/page/ios/ContentChangeObserver.cpp
-                // * https://github.com/WebKit/WebKit/blob/58956cf59ba01267644b5e8fe766efa7aa6f0c5c/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm#L783
-                role="button"
-                style={{
-                  backgroundColor:
-                    highlightedIndex === idx
-                      ? theme.menuAutoCompleteBackgroundHover
-                      : 'transparent',
-                  borderRadius: embedded ? 4 : 0,
-                  flexShrink: 0,
-                  flexDirection: 'row',
-                  alignItems: 'center',
-                  fontSize: 11,
-                  fontWeight: 500,
-                  color: theme.noticeTextMenu,
-                  padding: '6px 8px',
-                  ':active': {
-                    backgroundColor: 'rgba(100, 100, 100, .25)',
-                  },
-                }}
-                data-testid="split-transaction-button"
-              >
-                <Text style={{ lineHeight: 0 }}>
-                  <Split width={10} height={10} style={{ marginRight: 5 }} />
-                </Text>
-                Split Transaction
-              </View>
-            );
-          }
-
-          const showGroup = item.cat_group !== lastGroup;
-          lastGroup = item.cat_group;
-          return (
-            <Fragment key={item.id}>
-              {showGroup && (
-                <div
+        {items
+          .filter(item => !item.hidden)
+          .map((item, idx) => {
+            if (item.id === 'split') {
+              return (
+                <View
+                  key="split"
+                  {...(getItemProps ? getItemProps({ item }) : null)}
+                  // Downshift calls `setTimeout(..., 250)` in the `onMouseMove`
+                  // event handler they set on this element. When this code runs
+                  // in WebKit on touch-enabled devices, taps on this element end
+                  // up not triggering the `onClick` event (and therefore delaying
+                  // response to user input) until after the `setTimeout` callback
+                  // finishes executing. This is caused by content observation code
+                  // that implements various strategies to prevent the user from
+                  // accidentally clicking content that changed as a result of code
+                  // run in the `onMouseMove` event.
+                  //
+                  // Long story short, we don't want any delay here between the user
+                  // tapping and the resulting action being performed. It turns out
+                  // there's some "fast path" logic that can be triggered in various
+                  // ways to force WebKit to bail on the content observation process.
+                  // One of those ways is setting `role="button"` (or a number of
+                  // other aria roles) on the element, which is what we're doing here.
+                  //
+                  // ref:
+                  // * https://github.com/WebKit/WebKit/blob/447d90b0c52b2951a69df78f06bb5e6b10262f4b/LayoutTests/fast/events/touch/ios/content-observation/400ms-hover-intent.html
+                  // * https://github.com/WebKit/WebKit/blob/58956cf59ba01267644b5e8fe766efa7aa6f0c5c/Source/WebCore/page/ios/ContentChangeObserver.cpp
+                  // * https://github.com/WebKit/WebKit/blob/58956cf59ba01267644b5e8fe766efa7aa6f0c5c/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm#L783
+                  role="button"
                   style={{
-                    color: theme.menuAutoCompleteTextHeader,
-                    padding: '4px 9px',
-                    ...groupHeaderStyle,
-                  }}
-                  data-testid="category-item-group"
-                >
-                  {`${item.group?.name}`}
-                </div>
-              )}
-              <div
-                {...(getItemProps ? getItemProps({ item }) : null)}
-                // See comment above.
-                role="button"
-                className={`${css([
-                  {
                     backgroundColor:
                       highlightedIndex === idx
                         ? theme.menuAutoCompleteBackgroundHover
                         : 'transparent',
-                    padding: 4,
-                    paddingLeft: 20,
                     borderRadius: embedded ? 4 : 0,
-                  },
-                ])}`}
-                data-testid={
-                  'category-item' +
-                  (highlightedIndex === idx ? '-highlighted' : '')
-                }
-              >
-                {item.name}
-              </div>
-            </Fragment>
-          );
-        })}
+                    flexShrink: 0,
+                    flexDirection: 'row',
+                    alignItems: 'center',
+                    fontSize: 11,
+                    fontWeight: 500,
+                    color: theme.noticeTextMenu,
+                    padding: '6px 8px',
+                    ':active': {
+                      backgroundColor: 'rgba(100, 100, 100, .25)',
+                    },
+                  }}
+                  data-testid="split-transaction-button"
+                >
+                  <Text style={{ lineHeight: 0 }}>
+                    <Split width={10} height={10} style={{ marginRight: 5 }} />
+                  </Text>
+                  Split Transaction
+                </View>
+              );
+            }
+
+            const showGroup = item.cat_group !== lastGroup;
+            lastGroup = item.cat_group;
+            return (
+              <Fragment key={item.id}>
+                {showGroup && (
+                  <div
+                    style={{
+                      color: theme.menuAutoCompleteTextHeader,
+                      padding: '4px 9px',
+                      ...groupHeaderStyle,
+                    }}
+                    data-testid="category-item-group"
+                  >
+                    {`${item.group?.name}`}
+                  </div>
+                )}
+                <div
+                  {...(getItemProps ? getItemProps({ item }) : null)}
+                  // See comment above.
+                  role="button"
+                  className={`${css([
+                    {
+                      backgroundColor:
+                        highlightedIndex === idx
+                          ? theme.menuAutoCompleteBackgroundHover
+                          : 'transparent',
+                      padding: 4,
+                      paddingLeft: 20,
+                      borderRadius: embedded ? 4 : 0,
+                    },
+                  ])}`}
+                  data-testid={
+                    'category-item' +
+                    (highlightedIndex === idx ? '-highlighted' : '')
+                  }
+                >
+                  {item.name}
+                </div>
+              </Fragment>
+            );
+          })}
       </View>
       {footer}
     </View>