Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Back account syncing imports incorrect data (for two different banks) #1854

Closed
1 task done
Gaibhne opened this issue Nov 3, 2023 · 7 comments
Closed
1 task done
Labels
bank sync Related to automatic bank syncing bug Something isn't working

Comments

@Gaibhne
Copy link

Gaibhne commented Nov 3, 2023

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I import (via GoCardless, as per the readme) from two German banks (Sparkasse Aachen and ING DiBa), and both imports are incorrect - for the Sparkasse account, the note field is always empty, meaning the description of the transaction is not available at all, and for ING, all the notes start with mandatereference:,creditorid:,remittanceinformation:, making it impossible to see the actual note unless you click each field and scroll to the far right.

Any way to customize the sync details ? Those both seem like easy fixes I could trivially do myself if I could hook in somewhere or change the base config.

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Windows 10

@Gaibhne Gaibhne added the bug Something isn't working label Nov 3, 2023
@youngcw
Copy link
Member

youngcw commented Nov 3, 2023

If the data it correct from GoCardless, just not importing correct, you will need to setup a custom parser for the banks. There are a few in the codebase already

@Gaibhne
Copy link
Author

Gaibhne commented Nov 3, 2023

How would I go about that, and how would I check if the data it gets from GoCardless is correct ?

@youngcw
Copy link
Member

youngcw commented Nov 3, 2023

If you search around the discord you can find what other people have done. I don't use it so I don't know

@youngcw youngcw added the bank sync Related to automatic bank syncing label Nov 3, 2023
@Jackenmen
Copy link
Contributor

You can find a document as well as examples for how to do it here: https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless

@MatissJanis
Copy link
Member

👋 As others mentioned: the solution is to create a custom bank adapter. But best we can do is point you in the right direction. The actual implementation will need to be done by you.

@MatissJanis MatissJanis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
@s3rglx
Copy link

s3rglx commented Dec 6, 2023

You can find a document as well as examples for how to do it here: https://github.com/actualbudget/actual-server/tree/master/src/app-gocardless

Hello,
I've tried to follow these instructions. I guess, the documentation isn't up to date. The description to add new institutionId on client side code is deprecated. As far as I understood the client is fetching the available bank adapter data provided by the bank factory from server.

Correct me if I'm wrong.

@MatissJanis
Copy link
Member

No changes are necessary to the client-side anymore. Only server-side :)

I've drafted a PR to update the docs: actualbudget/actual-server#292

Thanks for the callout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bank sync Related to automatic bank syncing bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants