Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Import CSV not splitting on selected Delimiter #1793

Closed
1 task done
HBDK opened this issue Oct 14, 2023 · 8 comments
Closed
1 task done

[Bug]: Import CSV not splitting on selected Delimiter #1793

HBDK opened this issue Oct 14, 2023 · 8 comments
Labels
bug Something isn't working transaction import Related to manually importing transactions

Comments

@HBDK
Copy link

HBDK commented Oct 14, 2023

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

After updating to 23.10 the values shown in the Date, Payee, Notes and Amount drop downs are split on Comma and not the Delimiter selected in the Delimiter drop down.

when i downgrade to 23.9 it splits on the selected delimiter as expected.

changing the delimiter does not change it and i see no errors in the browser console.

Screenshot from 2023-10-14 14-58-17

i'm running Firefox 115.0

What error did you receive?

No response

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

@HBDK HBDK added the bug Something isn't working label Oct 14, 2023
@hippalectryon-0
Copy link

Can confirm, same here

@joel-jeremy joel-jeremy added help wanted Extra attention is needed transaction import Related to manually importing transactions labels Oct 14, 2023
@hippalectryon-0
Copy link

Actually, I believe this is the same as #1774 , so it should be fixed

@Marcus-Schubert
Copy link

As of today and running the latest available version (v23.10.0) I can confirm that this bug still exists.

@MikesGlitch
Copy link
Contributor

MikesGlitch commented Oct 29, 2023

As of today and running the latest available version (v23.10.0) I can confirm that this bug still exists.

I think this is fixed in the next release which will be v23.11.0. That'll get released in the next week or so.

@jlsjonas
Copy link
Contributor

jlsjonas commented Nov 11, 2023

I actually seem to have a very related but worse-presenting issue since 23.10.0 (23.11.0 isn't available yet on truecharts to validate the fix; posting for documentation purposes if the issue persists)

Using the following dummy csv:

"Uittreksel";"Datum";"Valuta datum";"Rekening";"Beschrijving";"Bedrag";"Valuta"
"2023/0010/0002";"31/10/2023";"31/10/2023";"";"Foo";"+ 123,12";"EUR"
"2023/0010/0001";"21/10/2023";"21/10/2023";"";"Bar";"- 1,23";"EUR"

it results in:
image

As my csv contains quotes, I suspect that the underlying issue will also be the delimiter selector (it is expecting a delimiter and seeing ; --the delimiter-- after all.

edit: confirmed suspicion by import working as expected when replacing ; with ,

@twk3
Copy link
Contributor

twk3 commented Dec 11, 2023

@jlsjonas Your sample data seems to be working now. (I just tested with v23.12.0)

I believe this issue can be closed. Fixed by #1774 in v23.11.0

@jlsjonas
Copy link
Contributor

👍 Confirmed working on my side too!
I suspect the underlying issue will also be resolved for the issue author.

@github-actions github-actions bot removed the help wanted Extra attention is needed label Dec 14, 2023
@HBDK
Copy link
Author

HBDK commented Dec 14, 2023

Sorry for the late reply, I finally got around to upgrading my instance and the error appears to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transaction import Related to manually importing transactions
Projects
None yet
Development

No branches or pull requests

7 participants