Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Rename "Nordigen" to "GoCardless" #1244

Closed
MatissJanis opened this issue Jul 1, 2023 · 6 comments
Closed

[Maintenance] Rename "Nordigen" to "GoCardless" #1244

MatissJanis opened this issue Jul 1, 2023 · 6 comments
Labels
maintenance Related to making the project easier to maintain

Comments

@MatissJanis
Copy link
Member

MatissJanis commented Jul 1, 2023 •
edited
Loading

Nordigen has been acquired and integrated in GoCardless. We should rename all usages of "nordigen" to "gocardless".

https://gocardless.com/bank-account-data/
@MatissJanis MatissJanis added the feature This issue is a feature request label Jul 1, 2023
@github-actions github-actions bot added the needs votes Please upvote this feature request if you would like to see it implemented! label Jul 1, 2023
@github-actions github-actions bot closed this as completed Jul 1, 2023
@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed maintenance Related to making the project easier to maintain and removed feature This issue is a feature request needs votes Please upvote this feature request if you would like to see it implemented! labels Jul 1, 2023
@MatissJanis MatissJanis reopened this Jul 1, 2023
@MatissJanis
Copy link
Member Author

Related:
We should also upgrade to nordigen-node v1.2.5 once it is released

nordigen/nordigen-node#49

@actualbudget actualbudget deleted a comment from github-actions bot Jul 1, 2023
@hofq hofq mentioned this issue Jul 1, 2023
Closed
1 task
@itsajay1029
Copy link

I'd love to work on this. Can you assign this to me @MatissJanis ?

@j-f1
Copy link
Contributor

j-f1 commented Jul 2, 2023

Hi @itsajay1029, we generally don’t assign issues to people but feel free to open a PR anyway!

@joel-jeremy joel-jeremy mentioned this issue Jul 17, 2023
Closed
@MatissJanis
Copy link
Member Author

Web: #1361

Server: needs to be done

Docs: needs to be done

@MatissJanis
Copy link
Member Author

Web & server: almost complete. Only remaining to rename nordigen_secretId and key id, but those will need some sort of smart migration in the short term.

Docs: needs to be done

@MatissJanis MatissJanis mentioned this issue Dec 15, 2023
Merged
@MatissJanis
Copy link
Member Author

Docs: done

Final change before closing this issue: actualbudget/actual-server#293

@MatissJanis MatissJanis removed help wanted Extra attention is needed good first issue Good for newcomers labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Related to making the project easier to maintain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MatissJanis @j-f1 @itsajay1029