From a3b031b6d752fb7e1ceea17e2811bd1d67e0592a Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Fri, 20 Sep 2024 15:08:57 +0200 Subject: [PATCH 01/10] fix --- .../Acts/TrackFitting/KalmanFitter.hpp | 46 ++++++++++--------- .../Acts/TrackFitting/detail/GsfActor.hpp | 5 +- .../detail/KalmanUpdateHelpers.hpp | 8 +++- 3 files changed, 35 insertions(+), 24 deletions(-) diff --git a/Core/include/Acts/TrackFitting/KalmanFitter.hpp b/Core/include/Acts/TrackFitting/KalmanFitter.hpp index 7e7001d00ad..db8a25e0df7 100644 --- a/Core/include/Acts/TrackFitting/KalmanFitter.hpp +++ b/Core/include/Acts/TrackFitting/KalmanFitter.hpp @@ -583,8 +583,8 @@ class KalmanFitter { const stepper_t& stepper, const navigator_t& navigator, result_type& result) const { // Try to find the surface in the measurement surfaces - auto sourcelink_it = inputMeasurements->find(surface->geometryId()); - if (sourcelink_it != inputMeasurements->end()) { + if (auto sourcelink_it = inputMeasurements->find(surface->geometryId()); + sourcelink_it != inputMeasurements->end()) { // Screen output message ACTS_VERBOSE("Measurement surface " << surface->geometryId() << " detected."); @@ -638,32 +638,36 @@ class KalmanFitter { // the lastTrackIndex. result.lastMeasurementIndex = result.lastTrackIndex; - } else if (surface->associatedDetectorElement() != nullptr || - surface->surfaceMaterial() != nullptr) { + } else if (const bool precedingMeasurementExists = + (result.measurementStates > 0), + surfaceIsSensitive = + (surface->associatedDetectorElement() != nullptr), + surfaceHasMaterial = (surface->surfaceMaterial() != nullptr); + (precedingMeasurementExists && surfaceIsSensitive) || + surfaceHasMaterial) { // We only create track states here if there is already measurement // detected or if the surface has material (no holes before the first // measurement) - if (result.measurementStates > 0 || - surface->surfaceMaterial() != nullptr) { - auto trackStateProxyRes = detail::kalmanHandleNoMeasurement( - state, stepper, *surface, *result.fittedStates, - result.lastTrackIndex, true, logger(), freeToBoundCorrection); - - if (!trackStateProxyRes.ok()) { - return trackStateProxyRes.error(); - } + auto trackStateProxyRes = detail::kalmanHandleNoMeasurement( + state, stepper, *surface, *result.fittedStates, + result.lastTrackIndex, true, logger(), precedingMeasurementExists, + freeToBoundCorrection); - const auto& trackStateProxy = *trackStateProxyRes; - result.lastTrackIndex = trackStateProxy.index(); + if (!trackStateProxyRes.ok()) { + return trackStateProxyRes.error(); + } - if (trackStateProxy.typeFlags().test(TrackStateFlag::HoleFlag)) { - // Count the missed surface - result.missedActiveSurfaces.push_back(surface); - } + const auto& trackStateProxy = *trackStateProxyRes; + result.lastTrackIndex = trackStateProxy.index(); - ++result.processedStates; + if (trackStateProxy.typeFlags().test(TrackStateFlag::HoleFlag)) { + // Count the missed surface + result.missedActiveSurfaces.push_back(surface); } - if (surface->surfaceMaterial() != nullptr) { + + ++result.processedStates; + + if (surfaceHasMaterial) { // Update state and stepper with material effects materialInteractor(surface, state, stepper, navigator, MaterialUpdateStage::FullUpdate); diff --git a/Core/include/Acts/TrackFitting/detail/GsfActor.hpp b/Core/include/Acts/TrackFitting/detail/GsfActor.hpp index 7db377d1ced..15c8505f72f 100644 --- a/Core/include/Acts/TrackFitting/detail/GsfActor.hpp +++ b/Core/include/Acts/TrackFitting/detail/GsfActor.hpp @@ -634,6 +634,8 @@ struct GsfActor { bool doCovTransport) const { const auto& surface = *navigator.currentSurface(state.navigation); + const bool precedingMeasurementExists = result.processedStates > 0; + // Initialize as true, so that any component can flip it. However, all // components should behave the same bool is_hole = true; @@ -647,7 +649,8 @@ struct GsfActor { // now until we measure this is significant auto trackStateProxyRes = detail::kalmanHandleNoMeasurement( singleState, singleStepper, surface, tmpStates.traj, - MultiTrajectoryTraits::kInvalid, doCovTransport, logger()); + MultiTrajectoryTraits::kInvalid, doCovTransport, logger(), + precedingMeasurementExists); if (!trackStateProxyRes.ok()) { return trackStateProxyRes.error(); diff --git a/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp b/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp index 62e50edbeea..8fcf29db8f7 100644 --- a/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp +++ b/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp @@ -135,7 +135,7 @@ template auto kalmanHandleNoMeasurement( propagator_state_t &state, const stepper_t &stepper, const Surface &surface, traj_t &fittedStates, const std::size_t lastTrackIndex, bool doCovTransport, - const Logger &logger, + const Logger &logger, const bool precedingMeasurementExists, const FreeToBoundCorrection &freeToBoundCorrection = FreeToBoundCorrection( false)) -> Result { // Add a TrackState entry multi trajectory. This allocates storage for @@ -177,10 +177,14 @@ auto kalmanHandleNoMeasurement( if (surface.surfaceMaterial() != nullptr) { typeFlags.set(TrackStateFlag::MaterialFlag); } - if (surface.associatedDetectorElement() != nullptr) { + if (surface.associatedDetectorElement() != nullptr && + precedingMeasurementExists) { ACTS_VERBOSE("Detected hole on " << surface.geometryId()); // If the surface is sensitive, set the hole type flag typeFlags.set(TrackStateFlag::HoleFlag); + } else if (surface.associatedDetectorElement() != nullptr) { + ACTS_VERBOSE("Skip hole (no preceding measurements) on surface " + << surface.geometryId()); } else if (surface.surfaceMaterial() != nullptr) { ACTS_VERBOSE("Detected in-sensitive surface " << surface.geometryId()); } From db133be54ac7e3fc35cf553eaf51f2bb4a8f5adb Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Fri, 20 Sep 2024 22:38:03 +0200 Subject: [PATCH 02/10] sonarcloud --- Core/include/Acts/TrackFitting/KalmanFitter.hpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Core/include/Acts/TrackFitting/KalmanFitter.hpp b/Core/include/Acts/TrackFitting/KalmanFitter.hpp index db8a25e0df7..e1ad0b90cdb 100644 --- a/Core/include/Acts/TrackFitting/KalmanFitter.hpp +++ b/Core/include/Acts/TrackFitting/KalmanFitter.hpp @@ -582,9 +582,14 @@ class KalmanFitter { Result filter(const Surface* surface, propagator_state_t& state, const stepper_t& stepper, const navigator_t& navigator, result_type& result) const { + const bool precedingMeasurementExists = (result.measurementStates > 0); + const bool surfaceIsSensitive = + (surface->associatedDetectorElement() != nullptr); + const bool surfaceHasMaterial = (surface->surfaceMaterial() != nullptr); + const auto sourcelink_it = inputMeasurements->find(surface->geometryId()); + // Try to find the surface in the measurement surfaces - if (auto sourcelink_it = inputMeasurements->find(surface->geometryId()); - sourcelink_it != inputMeasurements->end()) { + if (sourcelink_it != inputMeasurements->end()) { // Screen output message ACTS_VERBOSE("Measurement surface " << surface->geometryId() << " detected."); @@ -638,12 +643,7 @@ class KalmanFitter { // the lastTrackIndex. result.lastMeasurementIndex = result.lastTrackIndex; - } else if (const bool precedingMeasurementExists = - (result.measurementStates > 0), - surfaceIsSensitive = - (surface->associatedDetectorElement() != nullptr), - surfaceHasMaterial = (surface->surfaceMaterial() != nullptr); - (precedingMeasurementExists && surfaceIsSensitive) || + } else if ((precedingMeasurementExists && surfaceIsSensitive) || surfaceHasMaterial) { // We only create track states here if there is already measurement // detected or if the surface has material (no holes before the first From 185e05247ef5a54a881a86a31a3809ebfa13c6e8 Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Fri, 20 Sep 2024 22:46:11 +0200 Subject: [PATCH 03/10] update hashes --- Examples/Python/tests/root_file_hashes.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt index 547d53b9a78..193e777aa08 100644 --- a/Examples/Python/tests/root_file_hashes.txt +++ b/Examples/Python/tests/root_file_hashes.txt @@ -77,15 +77,15 @@ test_ML_Ambiguity_Solver__performance_ambiML.root: 284ff5c3a08c0b810938e4ac2f8ba test_refitting[odd]__trackstates_gsf_refit.root: 33de1e46b05abc450ff89aebc728d7cb85e3f4dc90e5a21fc79a1ed8e9e04d7d test_refitting[odd]__tracksummary_gsf_refit.root: 16951808df6363d2acb99e385aec35ad723b634403ca0724a552ae9d3a2ae237 test_refitting[generic]__trackstates_gsf_refit.root: ae07a875975a416d323d98b4b16dd3edc5ae672a8993ecb624758a770afdffbd -test_refitting[generic]__tracksummary_gsf_refit.root: bf46a89e429fa77a380d5ee48babb8af2044196eff872825e84c0d4401357114 -test_truth_tracking_kalman[generic-False-0.0]__trackstates_kf.root: c2a351bb12b81a69549ca0229d36369cb63cbc53a924f0fd0520879d214b9134 -test_truth_tracking_kalman[generic-False-0.0]__tracksummary_kf.root: bf46a89e429fa77a380d5ee48babb8af2044196eff872825e84c0d4401357114 +test_refitting[generic]__tracksummary_gsf_refit.root: 9dd347fcab40d1045bd48e1d7e531fbc9f1e07a2e7e321f196250721befe086c +test_truth_tracking_kalman[generic-False-0.0]__trackstates_kf.root: 4e49258ae95ef7b7c59ef155545323fbee6de3f160a0cd975225c0458ec27912 +test_truth_tracking_kalman[generic-False-0.0]__tracksummary_kf.root: 9dd347fcab40d1045bd48e1d7e531fbc9f1e07a2e7e321f196250721befe086c test_truth_tracking_kalman[generic-False-1000.0]__trackstates_kf.root: 0a2428ff260466f7fe4ea44863664afa3c7e34b0dc388e43ee096d132f3acefb -test_truth_tracking_kalman[generic-False-1000.0]__tracksummary_kf.root: 055a74d2747d360398cc846cc2791204491528896de78cca66b188e3ff530dc1 -test_truth_tracking_kalman[generic-True-0.0]__trackstates_kf.root: c2a351bb12b81a69549ca0229d36369cb63cbc53a924f0fd0520879d214b9134 -test_truth_tracking_kalman[generic-True-0.0]__tracksummary_kf.root: bf46a89e429fa77a380d5ee48babb8af2044196eff872825e84c0d4401357114 +test_truth_tracking_kalman[generic-False-1000.0]__tracksummary_kf.root: 8be4bcc0f05c90ffeb4ea7bbb517adee217550d59c2eed89a48ed3b4c5145c54 +test_truth_tracking_kalman[generic-True-0.0]__trackstates_kf.root: 4e49258ae95ef7b7c59ef155545323fbee6de3f160a0cd975225c0458ec27912 +test_truth_tracking_kalman[generic-True-0.0]__tracksummary_kf.root: 9dd347fcab40d1045bd48e1d7e531fbc9f1e07a2e7e321f196250721befe086c test_truth_tracking_kalman[generic-True-1000.0]__trackstates_kf.root: 0a2428ff260466f7fe4ea44863664afa3c7e34b0dc388e43ee096d132f3acefb -test_truth_tracking_kalman[generic-True-1000.0]__tracksummary_kf.root: 055a74d2747d360398cc846cc2791204491528896de78cca66b188e3ff530dc1 +test_truth_tracking_kalman[generic-True-1000.0]__tracksummary_kf.root: 8be4bcc0f05c90ffeb4ea7bbb517adee217550d59c2eed89a48ed3b4c5145c54 test_truth_tracking_kalman[odd-False-0.0]__trackstates_kf.root: a34546ba6cfdbecc3bcf6f02ec782ebcc76f332070e7ff8a64207ed815f65c7e test_truth_tracking_kalman[odd-False-0.0]__tracksummary_kf.root: 7f1bb68b39e52da7a77ea295819fa3776e947568455338738c3a6436c2d7599c test_truth_tracking_kalman[odd-False-1000.0]__trackstates_kf.root: 0344aa50ba6c14152cf0f29b6f6da8af88fd61556a99baa62bef2fdbbc121ac8 From 90b4aee02d0961505baa4c144680bac3ce33ab03 Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Wed, 25 Sep 2024 09:51:08 +0200 Subject: [PATCH 04/10] review andiwand --- Core/include/Acts/TrackFitting/KalmanFitter.hpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Core/include/Acts/TrackFitting/KalmanFitter.hpp b/Core/include/Acts/TrackFitting/KalmanFitter.hpp index e1ad0b90cdb..41b599e78a8 100644 --- a/Core/include/Acts/TrackFitting/KalmanFitter.hpp +++ b/Core/include/Acts/TrackFitting/KalmanFitter.hpp @@ -586,10 +586,10 @@ class KalmanFitter { const bool surfaceIsSensitive = (surface->associatedDetectorElement() != nullptr); const bool surfaceHasMaterial = (surface->surfaceMaterial() != nullptr); - const auto sourcelink_it = inputMeasurements->find(surface->geometryId()); + const auto sourceLinkIt = inputMeasurements->find(surface->geometryId()); // Try to find the surface in the measurement surfaces - if (sourcelink_it != inputMeasurements->end()) { + if (sourceLinkIt != inputMeasurements->end()) { // Screen output message ACTS_VERBOSE("Measurement surface " << surface->geometryId() << " detected."); @@ -605,7 +605,7 @@ class KalmanFitter { // point in performing globalToLocal correction) auto trackStateProxyRes = detail::kalmanHandleMeasurement( *calibrationContext, state, stepper, extensions, *surface, - sourcelink_it->second, *result.fittedStates, result.lastTrackIndex, + sourceLinkIt->second, *result.fittedStates, result.lastTrackIndex, false, logger()); if (!trackStateProxyRes.ok()) { @@ -695,8 +695,8 @@ class KalmanFitter { const navigator_t& navigator, result_type& result) const { // Try to find the surface in the measurement surfaces - auto sourcelink_it = inputMeasurements->find(surface->geometryId()); - if (sourcelink_it != inputMeasurements->end()) { + auto sourceLinkIt = inputMeasurements->find(surface->geometryId()); + if (sourceLinkIt != inputMeasurements->end()) { // Screen output message ACTS_VERBOSE("Measurement surface " << surface->geometryId() @@ -757,7 +757,7 @@ class KalmanFitter { // We have predicted parameters, so calibrate the uncalibrated input // measurement extensions.calibrator(state.geoContext, *calibrationContext, - sourcelink_it->second, trackStateProxy); + sourceLinkIt->second, trackStateProxy); // If the update is successful, set covariance and auto updateRes = @@ -1099,7 +1099,7 @@ class KalmanFitter { ACTS_VERBOSE("Preparing " << std::distance(it, end) << " input measurements"); std::map inputMeasurements; - // for (const auto& sl : sourcelinks) { + // for (const auto& sl : sourceLinks) { for (; it != end; ++it) { SourceLink sl = *it; const Surface* surface = kfOptions.extensions.surfaceAccessor(sl); From b6e32d529612ae709d48e4a991dc88e030000ff2 Mon Sep 17 00:00:00 2001 From: "Alexander J. Pfleger" <70842573+AJPfleger@users.noreply.github.com> Date: Wed, 25 Sep 2024 22:32:36 +0200 Subject: [PATCH 05/10] Update KalmanFitter.hpp --- Core/include/Acts/TrackFitting/KalmanFitter.hpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Core/include/Acts/TrackFitting/KalmanFitter.hpp b/Core/include/Acts/TrackFitting/KalmanFitter.hpp index ee889cba55b..88226d2e9a4 100644 --- a/Core/include/Acts/TrackFitting/KalmanFitter.hpp +++ b/Core/include/Acts/TrackFitting/KalmanFitter.hpp @@ -594,7 +594,6 @@ class KalmanFitter { const bool surfaceIsSensitive = (surface->associatedDetectorElement() != nullptr); const bool surfaceHasMaterial = (surface->surfaceMaterial() != nullptr); - const auto sourceLinkIt = inputMeasurements->find(surface->geometryId()); // Try to find the surface in the measurement surfaces auto sourceLinkIt = inputMeasurements->find(surface->geometryId()); From a39e7c64668ed28de9bdc6ddc871c6c3e4fd2c65 Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Thu, 26 Sep 2024 11:07:32 +0200 Subject: [PATCH 06/10] merge conflicts --- Core/include/Acts/TrackFitting/KalmanFitter.hpp | 6 +++--- .../TrackFitting/detail/KalmanUpdateHelpers.hpp | 14 +++++++++----- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/Core/include/Acts/TrackFitting/KalmanFitter.hpp b/Core/include/Acts/TrackFitting/KalmanFitter.hpp index 88226d2e9a4..4ca7d4ea555 100644 --- a/Core/include/Acts/TrackFitting/KalmanFitter.hpp +++ b/Core/include/Acts/TrackFitting/KalmanFitter.hpp @@ -590,10 +590,10 @@ class KalmanFitter { Result filter(const Surface* surface, propagator_state_t& state, const stepper_t& stepper, const navigator_t& navigator, result_type& result) const { - const bool precedingMeasurementExists = (result.measurementStates > 0); + const bool precedingMeasurementExists = result.measurementStates > 0; const bool surfaceIsSensitive = - (surface->associatedDetectorElement() != nullptr); - const bool surfaceHasMaterial = (surface->surfaceMaterial() != nullptr); + surface->associatedDetectorElement() != nullptr; + const bool surfaceHasMaterial = surface->surfaceMaterial() != nullptr; // Try to find the surface in the measurement surfaces auto sourceLinkIt = inputMeasurements->find(surface->geometryId()); diff --git a/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp b/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp index 89a51549be0..97048586781 100644 --- a/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp +++ b/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp @@ -172,20 +172,24 @@ auto kalmanHandleNoMeasurement( } // Set the track state flags + const bool surfaceHasMaterial = surface->surfaceMaterial() != nullptr; + const bool surfaceIsSensitive = + surface.associatedDetectorElement() != nullptr; auto typeFlags = trackStateProxy.typeFlags(); typeFlags.set(TrackStateFlag::ParameterFlag); - if (surface.surfaceMaterial() != nullptr) { + + if (surfaceHasMaterial) { typeFlags.set(TrackStateFlag::MaterialFlag); } - if (surface.associatedDetectorElement() != nullptr && - precedingMeasurementExists) { + + if (surfaceIsSensitive && precedingMeasurementExists) { ACTS_VERBOSE("Detected hole on " << surface.geometryId()); // If the surface is sensitive, set the hole type flag typeFlags.set(TrackStateFlag::HoleFlag); - } else if (surface.associatedDetectorElement() != nullptr) { + } else if (surfaceIsSensitive) { ACTS_VERBOSE("Skip hole (no preceding measurements) on surface " << surface.geometryId()); - } else if (surface.surfaceMaterial() != nullptr) { + } else if (surfaceHasMaterial) { ACTS_VERBOSE("Detected in-sensitive surface " << surface.geometryId()); } From 0c0aaa27c32fdaa321e2bb08271cca24f696156c Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Thu, 26 Sep 2024 11:03:43 +0200 Subject: [PATCH 07/10] rename variable in scope --- Core/include/Acts/TrackFitting/detail/GsfActor.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Core/include/Acts/TrackFitting/detail/GsfActor.hpp b/Core/include/Acts/TrackFitting/detail/GsfActor.hpp index 3573995396a..3bdfc60c785 100644 --- a/Core/include/Acts/TrackFitting/detail/GsfActor.hpp +++ b/Core/include/Acts/TrackFitting/detail/GsfActor.hpp @@ -638,7 +638,7 @@ struct GsfActor { // Initialize as true, so that any component can flip it. However, all // components should behave the same - bool is_hole = true; + bool isHole = true; auto cmps = stepper.componentIterable(state.stepping); for (auto cmp : cmps) { @@ -659,7 +659,7 @@ struct GsfActor { const auto& trackStateProxy = *trackStateProxyRes; if (!trackStateProxy.typeFlags().test(TrackStateFlag::HoleFlag)) { - is_hole = false; + isHole = false; } tmpStates.tips.push_back(trackStateProxy.index()); @@ -667,7 +667,7 @@ struct GsfActor { } // These things should only be done once for all components - if (is_hole) { + if (isHole) { ++result.measurementHoles; } From fcf3db7d93226d2e1eb04d37ecc5df7b883ada70 Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Thu, 26 Sep 2024 11:05:10 +0200 Subject: [PATCH 08/10] review andiwand 2B - remove material check --- Core/include/Acts/TrackFitting/KalmanFitter.hpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Core/include/Acts/TrackFitting/KalmanFitter.hpp b/Core/include/Acts/TrackFitting/KalmanFitter.hpp index 4ca7d4ea555..c6cd9b01976 100644 --- a/Core/include/Acts/TrackFitting/KalmanFitter.hpp +++ b/Core/include/Acts/TrackFitting/KalmanFitter.hpp @@ -675,11 +675,9 @@ class KalmanFitter { ++result.processedStates; - if (surfaceHasMaterial) { - // Update state and stepper with material effects - materialInteractor(surface, state, stepper, navigator, - MaterialUpdateStage::FullUpdate); - } + // Update state and stepper with (possible) material effects + materialInteractor(surface, state, stepper, navigator, + MaterialUpdateStage::FullUpdate); } return Result::success(); } From 6a8e939e40d23d9000cb948498bb315c52b33885 Mon Sep 17 00:00:00 2001 From: "Alexander J. Pfleger" <70842573+AJPfleger@users.noreply.github.com> Date: Thu, 26 Sep 2024 11:27:48 +0200 Subject: [PATCH 09/10] fix -> to . --- Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp b/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp index 97048586781..332d173f09d 100644 --- a/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp +++ b/Core/include/Acts/TrackFitting/detail/KalmanUpdateHelpers.hpp @@ -172,7 +172,7 @@ auto kalmanHandleNoMeasurement( } // Set the track state flags - const bool surfaceHasMaterial = surface->surfaceMaterial() != nullptr; + const bool surfaceHasMaterial = surface.surfaceMaterial() != nullptr; const bool surfaceIsSensitive = surface.associatedDetectorElement() != nullptr; auto typeFlags = trackStateProxy.typeFlags(); From 34b172bb375e16b54583085d686b0a8deb4ad6e9 Mon Sep 17 00:00:00 2001 From: AJPfleger Date: Thu, 26 Sep 2024 15:34:42 +0200 Subject: [PATCH 10/10] update hashes --- Examples/Python/tests/root_file_hashes.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Examples/Python/tests/root_file_hashes.txt b/Examples/Python/tests/root_file_hashes.txt index cbcf0d85720..54ffad36b9d 100644 --- a/Examples/Python/tests/root_file_hashes.txt +++ b/Examples/Python/tests/root_file_hashes.txt @@ -77,15 +77,15 @@ test_ML_Ambiguity_Solver__performance_ambiML.root: 284ff5c3a08c0b810938e4ac2f8ba test_refitting[odd]__trackstates_gsf_refit.root: 798a5b2e6d4b6d56e73ad107887f310c9463cc739ca1b69dad4a99d3419943ca test_refitting[odd]__tracksummary_gsf_refit.root: 16951808df6363d2acb99e385aec35ad723b634403ca0724a552ae9d3a2ae237 test_refitting[generic]__trackstates_gsf_refit.root: b044574ab5dec9781ca2a1d72095f2393270766365a0e165904ff628191c284a -test_refitting[generic]__tracksummary_gsf_refit.root: 6f8bd054c663197a5f5523e54ebc9695759b671eb14791f964073ed3c8a6f27f -test_truth_tracking_kalman[generic-False-0.0]__trackstates_kf.root: 64a7f26c30f5a70e323dc5d43142a7cc81ad7ef04033095a1ae11d27c41333f0 -test_truth_tracking_kalman[generic-False-0.0]__tracksummary_kf.root: 6f8bd054c663197a5f5523e54ebc9695759b671eb14791f964073ed3c8a6f27f +test_refitting[generic]__tracksummary_gsf_refit.root: 5b9ae5be9e82b2a1fd27d54fae5b9d8e89574f7a04a68cd491d4e3761c8fb834 +test_truth_tracking_kalman[generic-False-0.0]__trackstates_kf.root: 673a2b6a6fe855e8fcc3f0005a8d598ad61fd696177f54b2fa1af36517ac8f44 +test_truth_tracking_kalman[generic-False-0.0]__tracksummary_kf.root: 5b9ae5be9e82b2a1fd27d54fae5b9d8e89574f7a04a68cd491d4e3761c8fb834 test_truth_tracking_kalman[generic-False-1000.0]__trackstates_kf.root: e69d1aacacecc3d7d6619605cdd179d9fb0e19734f7c35345284f9a0e01f36d1 -test_truth_tracking_kalman[generic-False-1000.0]__tracksummary_kf.root: 055a74d2747d360398cc846cc2791204491528896de78cca66b188e3ff530dc1 -test_truth_tracking_kalman[generic-True-0.0]__trackstates_kf.root: 64a7f26c30f5a70e323dc5d43142a7cc81ad7ef04033095a1ae11d27c41333f0 -test_truth_tracking_kalman[generic-True-0.0]__tracksummary_kf.root: 6f8bd054c663197a5f5523e54ebc9695759b671eb14791f964073ed3c8a6f27f +test_truth_tracking_kalman[generic-False-1000.0]__tracksummary_kf.root: 8be4bcc0f05c90ffeb4ea7bbb517adee217550d59c2eed89a48ed3b4c5145c54 +test_truth_tracking_kalman[generic-True-0.0]__trackstates_kf.root: 673a2b6a6fe855e8fcc3f0005a8d598ad61fd696177f54b2fa1af36517ac8f44 +test_truth_tracking_kalman[generic-True-0.0]__tracksummary_kf.root: 5b9ae5be9e82b2a1fd27d54fae5b9d8e89574f7a04a68cd491d4e3761c8fb834 test_truth_tracking_kalman[generic-True-1000.0]__trackstates_kf.root: e69d1aacacecc3d7d6619605cdd179d9fb0e19734f7c35345284f9a0e01f36d1 -test_truth_tracking_kalman[generic-True-1000.0]__tracksummary_kf.root: 055a74d2747d360398cc846cc2791204491528896de78cca66b188e3ff530dc1 +test_truth_tracking_kalman[generic-True-1000.0]__tracksummary_kf.root: 8be4bcc0f05c90ffeb4ea7bbb517adee217550d59c2eed89a48ed3b4c5145c54 test_truth_tracking_kalman[odd-False-0.0]__trackstates_kf.root: 22c9f39a8e9569499205c024f7075d4125aca111c0e580c0320d6d93696062d5 test_truth_tracking_kalman[odd-False-0.0]__tracksummary_kf.root: a6da8b8ca2cd0f09fcbae5d08885fa2aee39990f2f329ef659ef3c260141643a test_truth_tracking_kalman[odd-False-1000.0]__trackstates_kf.root: 214f3ded235a0da8d254e34f72253ee8d6dfa5b7f96040bccd760b51ee85a46f