Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint rules does not gives warning for VS Code #445

Closed
2 tasks done
ahmedy00 opened this issue Oct 13, 2023 · 6 comments
Closed
2 tasks done

Eslint rules does not gives warning for VS Code #445

ahmedy00 opened this issue Oct 13, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ahmedy00
Copy link
Contributor

Terms

Behavior

The new rules added in issue #424 work properly in Jetbrains IDEs (Pycharm, Intellij IDEA), but do not show the necessary warnings in VS Code.

@ahmedy00 ahmedy00 added the bug Something isn't working label Oct 13, 2023
@ahmedy00
Copy link
Contributor Author

@andrewtavis Could you assign it to me?

@andrewtavis
Copy link
Member

Sure thing, @ahmedy00! Appreciate you opening this up and looking into this further! 🙏

@ahmedy00
Copy link
Contributor Author

Hey @to-sta, when you have time I would like to discuss about this bug and benefit from your experience

@to-sta
Copy link
Collaborator

to-sta commented Oct 13, 2023

@ahmedy00 I looked a bit into the issue and found out that when I add the following into the .vscode/settings.json file:

{
  "eslint.validate": []
}

That vscode is starting to complain about the order. This is not an optimol solution though.

@ahmedy00 are you on matrix?

@andrewtavis At the moment we run formatting and type checks on the frontend, might make sense to add a linter as well (to gain independence of the IDE issues 😄).

@andrewtavis
Copy link
Member

Makes sense, @to-sta! Would you make an issue for that? :)

@andrewtavis
Copy link
Member

Closed via #448 and #452 🚀 Thanks for this, @ahmedy00 and @to-sta!

@github-project-automation github-project-automation bot moved this from Todo to Done in activist Board Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants