Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch sidebar menu logic to use layouts #1060

Open
2 tasks done
andrewtavis opened this issue Dec 11, 2024 · 4 comments
Open
2 tasks done

Switch sidebar menu logic to use layouts #1060

andrewtavis opened this issue Dec 11, 2024 · 4 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

In discussing some bugs for the platform, a decision was made that the current way that we're deriving the sidebar menus is brittle because it's being determined based on URL based checks. We should instead determine this based on the actual routes using layouts - i.e. all /organizations pages would have a layout with the given sidebar menu.

Contribution

Happy to look into this! 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Dec 11, 2024
@andrewtavis
Copy link
Member Author

Note here that we need to further hoist other component logic into the layouts, not just the sidebar :)

@andrewtavis
Copy link
Member Author

  • For /organization/UUID routes we want to be making one call on the layout level that then instantiates all needed components for a given page based on the route and getting the id
  • For /organizations/UUID/groups/UUID we would create a sub layout of the organizations layout to then bring in the organization through the parent layout
  • For /events/UUID we would need to do two different calls via the event layout

@kirasvg
Copy link

kirasvg commented Dec 27, 2024

Hi @andrewtavis ,I would like to work on this issue. Could you please assign it to me?

@andrewtavis
Copy link
Member Author

Hi @kirasvg 👋 This is a pretty pressing issue and is likely something that I'll pick up in the coming days. If something changes or I'm able to break it down a bit better then I'll let you know! As it stands there are just so many changes that will need to happen.

Thanks for your interest, and please let us know if there's something else you'd have interest in working on in the meantime!

@andrewtavis andrewtavis self-assigned this Jan 9, 2025
@andrewtavis andrewtavis moved this from Todo to In Progress in activist Board Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

2 participants