Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about twitter bootstrap? #468

Open
bmalets opened this issue Jan 12, 2016 · 5 comments
Open

What about twitter bootstrap? #468

bmalets opened this issue Jan 12, 2016 · 5 comments

Comments

@bmalets
Copy link

bmalets commented Jan 12, 2016

Hi guys!

Thank you for such a cool gem, it really facilitates and speeds up development.
But do you have in plans to replace a default theme with twitter-bootstrap? 😇

І have looked for bootstrap in active_scaffold's analogs, forks, issues and pull requests but did not found any results.

As I see in source code, it will be not easy....

Thanks,
@bmalets

@scambra
Copy link
Member

scambra commented Jan 12, 2016

no plan in changing theme, it may be a big work

@bmalets
Copy link
Author

bmalets commented Jan 12, 2016

Thanks for a quick answer.

@scambra
Copy link
Member

scambra commented Jan 13, 2016

I don't know much about twitter-bootstrap, but I guess html structure and classes needs to be changed, or maybe not changing classes, only adding them.

Also, I would rather to add twitter bootstrap as a theme, so people can choose current or twitter bootstrap. Probably views would be same, but included css would be current one or twitter-bootstrap ones.

What do you think? Were you thinking only on CSS or JS too?

@naaano
Copy link

naaano commented Mar 5, 2016

it gets weird when you mix bootstrap styles with base bootstrap.
It would be great if the theme would work back again. I would help to migrate.
JS shouldn't be much conflict, since AS is focused on functionality(remote calls, mostly) and bootstrap js is more about appearance effects.
The bigger deal i think it would be to adapt helpers, which need to include some classes and different markup in some cases.

@CCH4GITHUB
Copy link
Contributor

Hi Sergio

Yes, I agree that I would also rather to add twitter bootstrap as a theme, so people can choose current or twitter bootstrap :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants