Replace arrow constants with frozen strings

These constants are only used once in the code base and constant lookup is slower than frozen strings in MRI Ruby 2.2+.
activerecord-hackery · Jul 23, 2016 · c0dff33 · c0dff33
1 parent 5280ecf
commit c0dff33
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/ransack/constants.rb b/lib/ransack/constants.rb
@@ -1,8 +1,5 @@
 module Ransack
   module Constants
-    ASC_ARROW           = '&#9650;'.freeze
-    DESC_ARROW          = '&#9660;'.freeze
-
     OR                  = 'or'.freeze
     AND                 = 'and'.freeze
 

diff --git a/lib/ransack/helpers/form_helper.rb b/lib/ransack/helpers/form_helper.rb
@@ -198,8 +198,11 @@ def no_sort_direction_specified?(dir = @current_dir)
           end
 
           def direction_arrow
-            return Constants::DESC_ARROW if @current_dir == 'desc'.freeze
-            Constants::ASC_ARROW
+            if @current_dir == 'desc'.freeze
+              '&#9660;'.freeze
+            else
+              '&#9650;'.freeze
+            end
           end
 
           def direction_text(dir)